opensim-gui
opensim-gui copied to clipboard
Added Debian bullseye support for the installer
Brief summary of changes
Changed to use ID of OS instead of NAME Only use VERSION_ID if ID == "ubuntu"
Testing I've completed
Built on my own Debian bullseye/sid
Thanks for submitting this @marnunez, quick feedback:
- whitespace/tab changes makes it hard to see the actual diffs, can you fix that?
- In our current work-from-home environment, and moving forward it is hard to access/test linux installers, so it would be good to leverage/test the artifacts produced by github actions on actual machines running linux.
- Sorry about the autoformatting, my bad.
- I see what you mean, how would you suggest to approach this? There's no ready github actions build for a Debian environment, but something more fancy using self-hosted runners might be done if needed. As for now, I did build and install this PR with the Debian machine I'm using, for what it's worth...
@marnunez If you fix the formatting, and @halleysfifthinc approves the change (to make sure it doesn't break his changes, I don't have access to either platforms) that would be great. Also please include in this PR, adding your name to the list of contributors in the contributing.md file. Thank you
Regarding the Actions CI artifacts, I believe what @aymanhab is suggesting is to check that the installer produced by CI works by test installing it on your machine.
I have run the build script under Debian bullseye and found 1 issue : it needs default-jdk in the preinstalls.
However, the installation crashes very easily including on the examples. Not sure if this is a problem with any older libs included in debian