opensim-gui icon indicating copy to clipboard operation
opensim-gui copied to clipboard

Added Debian bullseye support for the installer

Open marnunez opened this issue 4 years ago • 5 comments

Brief summary of changes

Changed to use ID of OS instead of NAME Only use VERSION_ID if ID == "ubuntu"

Testing I've completed

Built on my own Debian bullseye/sid

marnunez avatar May 25 '20 23:05 marnunez

Thanks for submitting this @marnunez, quick feedback:

  1. whitespace/tab changes makes it hard to see the actual diffs, can you fix that?
  2. In our current work-from-home environment, and moving forward it is hard to access/test linux installers, so it would be good to leverage/test the artifacts produced by github actions on actual machines running linux.

aymanhab avatar May 26 '20 18:05 aymanhab

  1. Sorry about the autoformatting, my bad.
  2. I see what you mean, how would you suggest to approach this? There's no ready github actions build for a Debian environment, but something more fancy using self-hosted runners might be done if needed. As for now, I did build and install this PR with the Debian machine I'm using, for what it's worth...

marnunez avatar May 29 '20 16:05 marnunez

@marnunez If you fix the formatting, and @halleysfifthinc approves the change (to make sure it doesn't break his changes, I don't have access to either platforms) that would be great. Also please include in this PR, adding your name to the list of contributors in the contributing.md file. Thank you

aymanhab avatar Jun 03 '20 23:06 aymanhab

Regarding the Actions CI artifacts, I believe what @aymanhab is suggesting is to check that the installer produced by CI works by test installing it on your machine.

halleysfifthinc avatar Jun 08 '20 14:06 halleysfifthinc

I have run the build script under Debian bullseye and found 1 issue : it needs default-jdk in the preinstalls.

However, the installation crashes very easily including on the examples. Not sure if this is a problem with any older libs included in debian

artgodwin avatar Apr 27 '23 09:04 artgodwin