opensim-gui icon indicating copy to clipboard operation
opensim-gui copied to clipboard

Bones fail to colorize even though property has changed

Open aseth1 opened this issue 6 years ago • 10 comments

Steps to reproduce

Load any model and change the color of the geometry, e.g. bones.

Expected result

Expect color of property to be respected and have bones change color.

Actual result

screen shot 2019-02-10 at 10 51 20 pm

Environment and GUI version

OpenSim 4.0 release posted on SimTK. Both MacOSX and Windows.

aseth1 avatar Feb 11 '19 06:02 aseth1

@aseth1 I am only able to reproduce this behavior when I have had OpenSim open for a long time and my computer has gone to sleep, woken up. I think this could be related to #523 and not an issue on its own.

jenhicks avatar Feb 28 '19 22:02 jenhicks

I cannot edit the color of all or multiple bones even after restarting OpenSim and loading a model. I am having the same issue on my Mac. Even though the color property appears to be set correctly, for the color to appear I must edit the color of the individual geometry to some other color and then set the value back to the bone color for it to take effect.

aseth1 avatar Mar 04 '19 23:03 aseth1

I am testing with my Mac and the jumper model we used for the webinar. I can change the color of a body or the individual geometry (one at a time or via a multi-select) via the navigator Display -> Color dropdowns. Color gets updated immediately. I can also edit colors of geometry individually or multi-select via the Property Editor.

@aymanhab Any ideas on what could cause differences between what Ajay and I are seeing?

jenhicks avatar Mar 05 '19 00:03 jenhicks

My guess is that he's not doing GUI editing, instead he's modifying the file. It's possible the initialization sequence is different so bones show up first time in default colors. If you can save and load model with non default colors of bones that would prove one way or the other.

aymanhab avatar Mar 05 '19 00:03 aymanhab

I can save and load a model with non default bone colors (e.g. making the pelvis blue via GUI editing). When I load the model, the pelvis is blue (on initial load).

jenhicks avatar Mar 05 '19 00:03 jenhicks

Could be typo or format of edited colors then. Can we diff the files?

On Mon, Mar 4, 2019, 4:30 PM Jen Hicks [email protected] wrote:

I can save a load a model with non default bone colors.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/opensim-org/opensim-gui/issues/1104#issuecomment-469484153, or mute the thread https://github.com/notifications/unsubscribe-auth/ADyccEjSZeruzqhKM4WsT46v5BIb-QG9ks5vTbq9gaJpZM4aznTa .

aymanhab avatar Mar 05 '19 00:03 aymanhab

My guess is that he's not doing GUI editing, instead he's modifying the file.

Please look at the image in this issue. I use the GUI and the color picker to change colors. You can see that the values for "boney" bone color is correct but the bones remain white. I can change Geometry individually and even multiselect Geometry under a Body, it turns out, but I cannot change color via bodies->Display->Color although the properties do update. Has nothing to do with files.

aseth1 avatar Mar 05 '19 00:03 aseth1

Thanks for the additional detail @aseth1 . Confirming, as noted above that I don't see this behavior on my machine with the jumper model. Might there be differences due to the model used? Maybe it is easier to take a look in person.

jenhicks avatar Mar 05 '19 16:03 jenhicks

Since this doesn't reproduce for me or @jenhicks on arbitrary models, I assume this is model specific (@aseth1 can you check a different model). Bodies do not have Geometry of their own, the GUI instead collects Geometry attached to the body and applies the color/preference/etc. to them. This process apparently breaks for this specific model. Will need to have the model in hand to investigate, but likely the issue is related to how the various Geometry is attached to respective bodies or the presence of unexpected Geometry that breaks the "collection/traversal" process.

aymanhab avatar Mar 05 '19 17:03 aymanhab

The issue occurst when there is a missing geometry file anywhere in the model. In the case of the upper-extremity model, I didn't care about the hand geometry visualizing so I was ignoring the missing vtp file warnings. Apparently we cannot do that anymore.

aseth1 avatar Mar 07 '19 20:03 aseth1