opensim-gui icon indicating copy to clipboard operation
opensim-gui copied to clipboard

Able to run ScaleTool without model markers which leads to downstream Exception

Open aseth1 opened this issue 6 years ago • 2 comments

Steps to reproduce

Use any model with markers and setup ScaleTool without measurements but selecting a markers file where necessary. Run.

Expected result

Expect the Run button to remain disabled until there are model markers that can match specified measurements OR manual scale factors are supplied without input marker data.

Actual result

Free to hit Run, which produces: (include screen grabs where appropriate) image

Environment and GUI version

Windows OpenSim 4.0-2018-11-06-f8548147

aseth1 avatar Nov 08 '18 00:11 aseth1

Is this a new bug to 4.0?

jenhicks avatar Nov 08 '18 16:11 jenhicks

@jenhicks The comparison is hard because there are multiple scenarios that disable run button which basically does high level check on consistency of options (you could have no markers and manual scale all segments). Interestingly the exception is thrown by InveseKinematicsSolver and IK in 3.3 and 4.0 both allow the user to run and throw the same exception, except it's handled differently and shows in the messages window rather than a dialog.

aymanhab avatar Nov 08 '18 18:11 aymanhab