opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

Add `get_GeometryPath` as a wrapper function for `getGeometryPath` in OpenSim 4.5

Open cvhammond opened this issue 11 months ago • 3 comments

It seems that OpenSim 4.5 has removed get_GeometryPath() from the core library and associated MATLAB wrapper. Can you please add get_GeometryPath() as a wrapper for getGeometryPath() so as to ensure backwards compatibility for anyone who is migrating from OpenSim 4.4 to OpenSim 4.5?

cvhammond avatar Mar 07 '24 03:03 cvhammond

(See PR #3535 and upgrade notes for v4.5 in CHANGELOG.md.)

tkuchida avatar Mar 07 '24 05:03 tkuchida

Hi @cvhammond, getGeometryPath() is compatible with both OpenSim 4.4 and 4.5.

The get_ syntax is typically reserved for property methods, the unnamed property GeometryPath was removed in favor of the named property path of type AbstractGeometryPath. See the PR linked above for more details.

nickbianco avatar Mar 07 '24 15:03 nickbianco

I added a note to the OpenSim 4.5 release notes on Confluence.

nickbianco avatar Mar 07 '24 15:03 nickbianco

@cvhammond, thanks again for bringing this up, but since we do have the backwards compatible option we do not plan to add this wrapper for the reasons stated above.

nickbianco avatar Mar 18 '24 22:03 nickbianco