opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

RigidTendonMuscle fibervelocity computation lacks pennation angle effect

Open pepbos opened this issue 1 year ago • 0 comments

The fiberVelocity computation in RigidTendonMuscle does not take the pennation angular velocity into account. It appears to be correct only if the pennation angle is zero, which is not generally the case.

The fibervelocity computed by the RigidTendonMuscle is set to equal the muscle lengtheningspeed: https://github.com/opensim-org/opensim-core/blob/20752f3a7852854a3e95a0bf52832bc8ec788163/OpenSim/Actuators/RigidTendonMuscle.cpp#L164

This would be correct if the pennation angle is zero. But the pennation angle is generally not zero: https://github.com/opensim-org/opensim-core/blob/20752f3a7852854a3e95a0bf52832bc8ec788163/OpenSim/Actuators/RigidTendonMuscle.cpp#L138

It looks like the correct fibervelocity calculation can be found in Millard2012EquilibriumMuscle, with the ignore_tendon_compliance set to true: https://github.com/opensim-org/opensim-core/blob/20752f3a7852854a3e95a0bf52832bc8ec788163/OpenSim/Actuators/Millard2012EquilibriumMuscle.cpp#L996C32-L996C32

pepbos avatar Jan 12 '24 08:01 pepbos