opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

Published 20 hours ago • verified publisher icon opensim-org

build on osx-11

Open aymanhab opened this issue 2 years ago • 3 comments

Fixes issue #3289

Brief summary of changes

Add block for macos-11 in ci xml file

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

aymanhab avatar Sep 16 '22 19:09 aymanhab

@carmichaelong I added a build script option for mac osx 11 on ci since 10.15 will be retired soon, but I'm having build problem with Clang 13. What version did you use on your M1? I may upgrade my old macbook to BigSur/11 to test but will have no way back to test 10.15. Thanks

aymanhab avatar Sep 19 '22 15:09 aymanhab

I'm on OSX 12.4 with Clang 13.1.6.13160021. So I'm a little behind on minor OSX versions right now.

carmichaelong avatar Sep 19 '22 16:09 carmichaelong

@carmichaelong For your review, adding a block to build on osx 11 since 10.15 is soon to be retired. Had to disable one new warning due to clang upgrade that was breaking the build initially and would require more involved code changes.

aymanhab avatar Oct 04 '22 18:10 aymanhab

While the build on osx-11 succeeds, there are problems with RPATH of gcc libraries that show at runtime post install as described by @carmichaelong here https://github.com/opensim-org/opensim-gui/pull/1387

aymanhab avatar Oct 19 '22 20:10 aymanhab

I'll merge this since it only affects ci by adding osx11 build, and will allow us to test the fix to #3334

aymanhab avatar Dec 12 '22 18:12 aymanhab