opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

included MocoOutputExtremumGoal functionality

Open nicos1993 opened this issue 2 years ago • 1 comments

Brief summary of changes

Within MocoOutputGoal.h/.cpp I, with the help of Reed and Nick, have included a new goal, MocoOutputGoalExtremum, it is very similar to the original MocoOutputGoal. The goal permits the integration of only positive or negative values from a model output.

Testing I've completed

So far I have tested it locally on the walking_2d.cpp example and it is producing results as anticipated.

Looking for feedback on...

CHANGELOG.md (choose one)

I think I need to update the CHANGELOG_MOCO.md to include the 'MocoOutputGoalExtremum'.


This change is Reviewable

nicos1993 avatar Sep 12 '22 20:09 nicos1993

I will update for the MocoContactImpulseTrackingGoal for now. Will update for this once we resolve everything (?).

nicos1993 avatar Sep 14 '22 19:09 nicos1993

@nicos1993 actually, you should add an entry to the Moco changelog. Then were good to go.

nickbianco avatar Jan 19 '23 20:01 nickbianco

Great job @nicos1993!

nickbianco avatar Jan 20 '23 03:01 nickbianco