opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

Update ezc3d Version in Conda Package

Open teliason opened this issue 2 years ago • 5 comments

There is an incompatibility issue when both opensim and ezc3d are installed in the same environment and the ezc3d version does not match what opensim was built with (https://github.com/pyomeca/ezc3d/issues/220).

From my testing it looks like the current conda opensim package was built with ezc3d 1.4.7. If possible it would be super helpful if the conda package could be updated with the current ezc3d version 1.4.9.

Thank you for putting opensim together as a conda package. It has been great for streamlining integrating opensim into our python workflow.

teliason avatar May 23 '22 21:05 teliason

@pariterre Any suggestions on whether upgrading to this version of ezc3d has other side-effects. More of our users are relying on Ezc3d and are having issues with conda conflicts. Thank you

aymanhab avatar May 24 '22 16:05 aymanhab

Hi @teliason, I can push an update to the opensim software, but it won't be available to the actual software until further release (unless you are building OpenSim for yourself).

@aymanhab To my knowledge, there isn't any breaking changes from 1.4.7 to 1.4.9. If you want, I can push an update

pariterre avatar May 24 '22 20:05 pariterre

If not breaking we can go to latest released version, we have no reason to stay behind official released versions.

On Tue, May 24, 2022, 1:28 PM Pariterre @.***> wrote:

Hi @teliason https://github.com/teliason, I can push an update to the opensim software, but it won't be available to the actual software until further release (unless you are building OpenSim for yourself).

@aymanhab https://github.com/aymanhab To my knowledge, there isn't any breaking changes from 1.4.7 to 1.4.9. If you want, I can push an update

— Reply to this email directly, view it on GitHub https://github.com/opensim-org/opensim-core/issues/3209#issuecomment-1136399723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6JY4EFKMG74F6N7A7SHKLVLU3V7ANCNFSM5WXCFW7Q . You are receiving this because you were mentioned.Message ID: @.***>

aymanhab avatar May 24 '22 20:05 aymanhab

When I built OpenSim with ezc3d 1.4.9 everything worked as expected. I don't think the new version should break anything on the OpenSim side but I have not extensively tested it. @aymanhab that would be great if you could update to the latest, while I have it working by building OpenSim ourselves, the conda package is very convenient when sharing our pipeline internally and getting others who are less familiar with OpenSim set up.

teliason avatar May 24 '22 22:05 teliason

@teliason That is actually on me, but it only consists in updating the commit number and the version number in the dependencies folder. I wanted to build it myself before, but did not have time to do so. Since you tell me that it does not produce error (which I am actually not surprised), I will simply push the modif and trust the merge test on GitHub :)

pariterre avatar May 25 '22 12:05 pariterre

Conda package was published with ezc3d 1.5, thanks for the help @pariterre Closing

aymanhab avatar Sep 19 '22 17:09 aymanhab