opensim-core icon indicating copy to clipboard operation
opensim-core copied to clipboard

Published 20 hours ago • verified publisher icon opensim-org

Unify PostScale methods for Muscles

Open aymanhab opened this issue 3 years ago • 1 comments

Duplicated and identical PostScale methods for concrete Muscle subclasses are better moved to the base Muscle class.

aymanhab avatar Dec 07 '21 18:12 aymanhab

IIRC we had this discussion and the rationale (whether still valid or not) was that all classes derived from Muscle may not want to update ofl and tsl in the same way. However, yes it seems reasonable to just have Muscle make this decision for any derived class. ⛄

tkuchida avatar Dec 07 '21 19:12 tkuchida