openshwprojects
Configured channel sanity/conflict check logic
Not sure what's involved, but I'm a +1 voice for having some kind of channel selection check on the module configuration page to throw an exception or whatever if any of the non-preference channel selections conflict. eg if BAT_Relay and BAT_ADC are on the same channel it'll error on save. Conversely if there are any that need to be on the same channel, this is also an error event.
I guess this cannot be done for everything, for example, a user might want 3 LEDs to come on with 1 button toggle, whereas another user might have a device that has multiple LEDs and buttons and they're to be set as pairs. The sanity check would only be able to apply certain components.
Is this a legitimate request or is my thinking/understanding wrong?
I really like the idea, it would be a valuable addition to the page. It might suffer from the possible size of code that might need: For it's not done with the testing code, there would be the need for some explanation what's wrong and how to resolve the mismatch. The advanced users just making a simple mistake would be o.k. with "error, please check configuration", but most users would probably need a bit more text... But maybe this can be overcome by some kind of automated text derived from the checks (e.g. if the check is (BAT_Relay.channel == BAT_ACD.channel) then text could be simply "on the same channel: BAT_Relay and BAT_ADC", so user can do some research, why this is no valid configuration...)
Good idea, but the battery driver itself could be also maybe improved. Maybe it could function without taking channels into the account. I am not the one who wrote that driver so I am not sure ...
On Sat, May 25, 2024, 9:28 AM MaxineMuster @.***> wrote:
I really like the idea, it would be a valuable addition to the page. It might suffer from the possible size of code that might need: For it's not done with the testing code, there would be the need for some explanation what's wrong and how to resolve the mismatch. The advanced users just making a simple mistake would be o.k. with "error, please check configuration", but most users would probably need a bit more text... But maybe this can be overcome by some kind of automated text derived from the checks (e.g. if the check is (BAT_Relay.channel == BAT_ACD.channel) then text could be simply "on the same channel: BAT_Relay and BAT_ADC", so user can do some research, why this is no valid configuration...)
— Reply to this email directly, view it on GitHub https://github.com/openshwprojects/OpenBK7231T_App/issues/1248#issuecomment-2131049159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUMGZ67QXWLSBSO7SFO3KNDZEA4SZAVCNFSM6AAAAABIITSFDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGA2DSMJVHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
