openshift
[WIP]Migrate must-gather cases to origin
Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.
For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.
This repository is configured in: automatic mode
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: gangwgr Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
- periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
- periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
- periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4aa84eb0-d64f-11f0-842b-e5b61372c9eb-0
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
- periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
- periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
- periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8efd7b70-d650-11f0-8594-a87de3fee2d0-0
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.
New Test Risks for sha: 5d45978e4b345fbb8fed1e590578997a2f720cfe
| Job Name | New Test Risk |
|---|---|
| pull-ci-openshift-origin-main-e2e-aws-ovn-fips | High - "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-aws-ovn-fips | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-gcp-ovn | High - "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-gcp-ovn | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 | High - "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-vsphere-ovn | High - "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-vsphere-ovn | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi | High - "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
| pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" is a new test that failed 1 time(s) against the current commit |
New tests seen in this PR at sha: 5d45978e4b345fbb8fed1e590578997a2f720cfe
- "[sig-cli] oc adm must-gather Fetch audit logs of login attempts via oc commands timeout [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
- "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0]
- "[sig-cli] oc adm must-gather Verify version of oc binary is included into the must-gather directory when running oc adm must-gather command [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
- "[sig-cli] oc adm must-gather must-gather support since and since-time flags timeout [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
- "[sig-cli] oc adm must-gather oc adm inspect should support since and sincetime [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
- "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0]
![openshift-trt[bot] avatar](https://avatars.githubusercontent.com/u/111778100?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gangwgr: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips
- periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade
- periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
- periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-1of2
- periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-serial-2of2
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
- periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
- periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d2bcc90-d69b-11f0-8796-7e95dcc6b08d-0
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
@gangwgr: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:
/test e2e-aws-csi
/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test go-verify-deps
/test images
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-deps
The following commands are available to trigger optional jobs:
/test e2e-agnostic-ovn-cmd
/test e2e-aws-disruptive
/test e2e-aws-etcd-certrotation
/test e2e-aws-etcd-recovery
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kube-apiserver-rollout
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-serial-fast
/test e2e-aws-ovn-serial-ipsec
/test e2e-aws-ovn-serial-publicnet-1of2
/test e2e-aws-ovn-serial-publicnet-2of2
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-techpreview
/test e2e-aws-ovn-single-node-techpreview-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-rollback
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-azure-ovn-upgrade
/test e2e-baremetalds-kubevirt
/test e2e-external-aws
/test e2e-external-aws-ccm
/test e2e-external-vsphere-ccm
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial-1of2
/test e2e-gcp-fips-serial-2of2
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-kube-apiserver-rollout
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial-1of2
/test e2e-gcp-ovn-techpreview-serial-2of2
/test e2e-gcp-ovn-usernamespace
/test e2e-hypershift-conformance
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-bgp-virt-dualstack
/test e2e-metal-ipi-ovn-bgp-virt-dualstack-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-bgp
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-ovn-kube-apiserver-rollout
/test e2e-metal-ipi-serial-1of2
/test e2e-metal-ipi-serial-2of2
/test e2e-metal-ipi-serial-ovn-ipv6-1of2
/test e2e-metal-ipi-serial-ovn-ipv6-2of2
/test e2e-metal-ipi-virtualmedia
/test e2e-metal-ovn-single-node-live-iso
/test e2e-metal-ovn-single-node-with-worker-live-iso
/test e2e-metal-ovn-two-node-arbiter
/test e2e-metal-ovn-two-node-fencing
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-scos-e2e-aws-ovn
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-origin-main-go-verify-deps
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps
In response to this:
/retest required
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.
New tests seen in this PR at sha: d0c2dd86e9b3130ed979559c25c400581d2ed6f7
- "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 12, Pass: 12, Fail: 0, Flake: 0]
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.
New tests seen in this PR at sha: 594e2ba0da8685434e12544080ece494c9d15941
- "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
Based on my analysis of the CI job configurations and test suite definitions:
❌ NO - The must-gather tests CANNOT be executed in the 4.21 nightly blocking CI jobs you listed.
So we don't need to trigger 4.21 nightly blocking ci jobs.
Here's why:
- Test Tags Analysis: - The must-gather tests in test/extended/cli/mustgather.go are tagged with [sig-cli] and [apigroup:config.openshift.io] - They are NOT tagged with [Suite:openshift/conformance/parallel] or [Suite:openshift/conformance/serial]
- CI Job Configuration: All 13 jobs you listed run one of these test suites: - Upgrade jobs (4 jobs): Run upgrade-conformance suite - Serial jobs (5 jobs): Run openshift/conformance/serial suite - Regular/parallel jobs (4 jobs): Run openshift/conformance/parallel suite
- Test Suite Filtering: - The conformance test suites (defined in pkg/testsuites/standard_suites.go) explicitly filter for tests with conformance suite tags - Tests without these tags are excluded
Recommendation:
If you want the must-gather tests to run in these CI jobs, you need to:
- Add conformance suite tags to the tests in test/extended/cli/mustgather.go: g.It("runs successfully [Suite:openshift/conformance/parallel][apigroup:config.openshift.io]", func() {
- Or create dedicated CI jobs that run the sig-cli or all test suites specifically
Based on my analysis of the CI job configurations and test suite definitions:
❌ NO - The must-gather tests CANNOT be executed in the 4.21 nightly blocking CI jobs you listed.
So we don't need to trigger 4.21 nightly blocking ci jobs.
Here's why:
- Test Tags Analysis:
- The must-gather tests in test/extended/cli/mustgather.go are tagged with [sig-cli] and [apigroup:config.openshift.io]
- They are NOT tagged with [Suite:openshift/conformance/parallel] or [Suite:openshift/conformance/serial]
- CI Job Configuration: All 13 jobs you listed run one of these test suites:
- Upgrade jobs (4 jobs): Run upgrade-conformance suite
- Serial jobs (5 jobs): Run openshift/conformance/serial suite
- Regular/parallel jobs (4 jobs): Run openshift/conformance/parallel suite
- Test Suite Filtering:
- The conformance test suites (defined in pkg/testsuites/standard_suites.go) explicitly filter for tests with conformance suite tags
- Tests without these tags are excluded
Recommendation:
If you want the must-gather tests to run in these CI jobs, you need to:
- Add conformance suite tags to the tests in test/extended/cli/mustgather.go: g.It("runs successfully [Suite:openshift/conformance/parallel][apigroup:config.openshift.io]", func() {
- Or create dedicated CI jobs that run the sig-cli or all test suites specifically
these cases run in conformance/parallel suite "[sig-cli] oc adm must-gather Fetch audit logs of login attempts via oc commands timeout [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0] "[sig-cli] oc adm must-gather Verify logs generated are included in the must-gather directory when running the oc adm must-gather command timeout [apigroup:config.openshift.io][Timeout:30m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0] "[sig-cli] oc adm must-gather Verify version of oc binary is included into the must-gather directory when running oc adm must-gather command [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0] "[sig-cli] oc adm must-gather must-gather support since and since-time flags timeout [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0] "[sig-cli] oc adm must-gather oc adm inspect should support since and sincetime [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0] "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 0, Fail: 5, Flake: 0]
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.
New Test Risks for sha: dae5616983d4b9c04376fd8826e6390e3f50fddb
| Job Name | New Test Risk |
|---|---|
| pull-ci-openshift-origin-main-e2e-gcp-ovn | High - "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit. |
New tests seen in this PR at sha: dae5616983d4b9c04376fd8826e6390e3f50fddb
- "[sig-cli] oc adm must-gather run the must-gather command with own name space [apigroup:config.openshift.io][Timeout:20m] [Suite:openshift/conformance/parallel]" [Total: 6, Pass: 6, Fail: 0, Flake: 0]