OCPSTRAT-2728: Remove pod label length check in oc debug test

[jacobsee]

The PodTopologyLabelsAdmission feature has graduated to Beta and is enabled by default starting in 1.35-rc.0, adding extra labels to pods.

{  fail [github.com/openshift/origin/test/extended/cli/debug.go:316]: Expected
    <map[string]string | len:3>: {
        "debug.openshift.io/managed-by": "oc-debug",
        "topology.kubernetes.io/region": "us-east-2",
        "topology.kubernetes.io/zone": "us-east-2b",
    }
to have length 1}

Do we gain a benefit from ensuring that no extra labels are applied here? The number of labels will now differ between < 1.35 and >= 1.35 based versions of OCP, so extra logic will be necessary if so.

This is currently causing failures impacting the 1.35 rebase.

[openshift-ci-robot]

Pipeline controller notification This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi

[ngopalak-redhat]

/lgtm

[ardaguclu]

I agree that we can only check the presence of debug label. Thank you for fixing this /lgtm

[jacobsee]

Labeling after conversation with @bertinatto /label acknowledge-critical-fixes-only

[openshift-ci-robot]

@jacobsee: This pull request references OCPSTRAT-2728 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.22" instead.

In response to this:

The PodTopologyLabelsAdmission feature has graduated to Beta and is enabled by default starting in 1.35-rc.0, adding extra labels to pods.

{  fail [github.com/openshift/origin/test/extended/cli/debug.go:316]: Expected
   <map[string]string | len:3>: {
       "debug.openshift.io/managed-by": "oc-debug",
       "topology.kubernetes.io/region": "us-east-2",
       "topology.kubernetes.io/zone": "us-east-2b",
   }
to have length 1}

Do we gain a benefit from ensuring that no extra labels are applied here? The number of labels will now differ between < 1.35 and >= 1.35 based versions of OCP, so extra logic will be necessary if so.

This is currently causing failures impacting the 1.35 rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jacobsee]

/verified by ci

[openshift-ci-robot]

@jacobsee: This PR has been marked as verified by ci.

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bertinatto]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, bertinatto, jacobsee, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [bertinatto]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 737f7384774e6274ba48cd74392c9f4564889488 and 2 for PR HEAD dee10442dd83745baf89b02b7815ff0138294bd9 in total

[openshift-ci[bot]]

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.