openshift
STOR-2550: add LSO network policy test case
Adding LSO network policy test cases
LSO(and other 3rd Operator) test strategy: After discussing with the team, we decided not to install/uninstall the Operator/Operand during standard tests, as this would incur significant overhead across all our CI pipelines. Instead, we will define specific jobs where the Operator/Operand is pre-installed. This approach allows us to cover all configuration-related tests efficiently and with low cost.
Test records:
passed: (11.3s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels for LSO [Suite:openshift/conformance/parallel]"
passed: (11.1s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSI related Operators [Suite:openshift/conformance/parallel]"
passed: (11.6s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSO related Operators [Suite:openshift/conformance/parallel]"
passed: (11.8s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for LSO related resources [Suite:openshift/conformance/parallel]"
passed: (12.5s) 2025-12-03T13:17:00 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels [Suite:openshift/conformance/parallel]"
Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.
For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.
This repository is configured in: automatic mode
@duanwei33: This pull request references STOR-2550 which is a valid jira issue.
In response to this:
Adding LSO network policy test cases
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
@duanwei33: This pull request references STOR-2550 which is a valid jira issue.
In response to this:
Adding LSO network policy test cases
Test records:
passed: (11.3s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels for LSO [Suite:openshift/conformance/parallel]" passed: (11.1s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSI related Operators [Suite:openshift/conformance/parallel]" passed: (11.6s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSO related Operators [Suite:openshift/conformance/parallel]" passed: (11.8s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for LSO related resources [Suite:openshift/conformance/parallel]" passed: (12.5s) 2025-12-03T13:17:00 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels [Suite:openshift/conformance/parallel]"
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@duanwei33: This pull request references STOR-2550 which is a valid jira issue.
In response to this:
Adding LSO network policy test cases
LSO(and other 3rd Operator) test strategy: After discussing with the team, we decided not to install/uninstall the Operator/Operand during standard tests, as this would incur significant overhead across all our CI pipelines. Instead, we will define specific jobs where the Operator/Operand is pre-installed. This approach allows us to cover all configuration-related tests efficiently and with low cost.
Test records:
passed: (11.3s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels for LSO [Suite:openshift/conformance/parallel]" passed: (11.1s) 2025-12-03T13:16:58 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSI related Operators [Suite:openshift/conformance/parallel]" passed: (11.6s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for CSO related Operators [Suite:openshift/conformance/parallel]" passed: (11.8s) 2025-12-03T13:16:59 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should verify required labels for LSO related resources [Suite:openshift/conformance/parallel]" passed: (12.5s) 2025-12-03T13:17:00 "[sig-storage][OCPFeature:StorageNetworkPolicy] Storage Network Policy should ensure required NetworkPolicies exist with correct labels [Suite:openshift/conformance/parallel]"
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Instead, we will define specific jobs where the Operator/Operand is pre-installed. This approach allows us to cover all configuration-related tests efficiently and with low cost.
@duanwei33 Does this mean you will have a follow-up PR to openshift/release to define a new workflow to install LSO and run this test?
Instead, we will define specific jobs where the Operator/Operand is pre-installed. This approach allows us to cover all configuration-related tests efficiently and with low cost.
@duanwei33 Does this mean you will have a follow-up PR to openshift/release to define a new workflow to install LSO and run this test?
Yes you are right. wdyt of this idea?
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
Instead, we will define specific jobs where the Operator/Operand is pre-installed. This approach allows us to cover all configuration-related tests efficiently and with low cost.
@duanwei33 Does this mean you will have a follow-up PR to openshift/release to define a new workflow to install LSO and run this test?
Yes you are right. wdyt of this idea?
Works for me, just wanted to understand how it will run, since existing LSO presubmits don't call this (yet).
Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi
@duanwei33 I am no expert here but I see other people have LGTM'ed.
Please keep an eye on any blocking jobs that might fail with these changes and be ready to revert as needed.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: DennisPeriquet, dobsonj, duanwei33, Phaow
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [DennisPeriquet]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/label acknowledge-critical-fixes-only Needed to add coverage for new 4.21 feature.
@duanwei33: This PR has been marked as verified by CI.
In response to this:
/verified by CI
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 26236ded5ec68da1373d2622749e01fd89b6a2d2 and 2 for PR HEAD 2f726859e74d74611f688041b467d5d43f7ee190 in total
/retest-required
Remaining retests: 0 against base HEAD 89d0a8789661d980960d574cf8f01892a5ac006b and 1 for PR HEAD 2f726859e74d74611f688041b467d5d43f7ee190 in total
/retest-required
Remaining retests: 0 against base HEAD 553fdbc40c0129453c7dee4bb539ff719b978eb1 and 0 for PR HEAD 2f726859e74d74611f688041b467d5d43f7ee190 in total
@duanwei33: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.