origin icon indicating copy to clipboard operation
origin copied to clipboard

OCPNODE-3780: Add e2e tests to validate DRA APIs

Open sairameshv opened this issue 1 month ago • 13 comments

  • DynamicResourceAllocation feature has been graduated to GA upstream
  • These tests validate the v1alpha1, v1alpha2, v1beta1 APIs of DRA are disabled

Tests generated by Claude

cc: @tkashem @haircommander

sairameshv avatar Nov 05 '25 15:11 sairameshv

Job Failure Risk Analysis for sha: c97ac81924a4d13f909ecf86e40cb8b7af1ff68d

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-csi High
Undiagnosed panic detected in pod
This test has passed 99.93% of 2978 runs on release 4.21 [Overall] in the last week.

Open Bugs
Undiagnosed Panic: openshift-cloud-controller-manager_azure-cloud-node-manager

Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: c97ac81924a4d13f909ecf86e40cb8b7af1ff68d

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] server supports sending resources in Table format" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by client-go's List method when WatchListClient is enabled" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by metadata client's List method when WatchListClient is enabled" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] NoExecuteTaintManager Multiple Pods [Serial] only evicts pods without tolerations from tainted nodes" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] NoExecuteTaintManager Single Pod [Serial] pods evicted from tainted nodes have pod disruption condition" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-node] Pod Level Resources [Serial] [Feature:PodLevelResources] [FeatureGate:PodLevelResources] [Beta] Burstable QoS pod, 1 container with resources" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-scheduling] Multi-AZ Clusters should spread the pods of a service across zones [Serial]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-scheduling] SchedulerPredicates [Serial] PodTopologySpread Filtering validates 4 pods with MaxSkew=1 are evenly distributed into 2 nodes" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is bumped on two Pods with a different context on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] CSI Mock selinux on mount metrics and SELinuxWarningController SELinuxMount metrics [LinuxOnly] [Feature:SELinux] [Serial] warning is bumped on two Pods with different policies on RWO volume [FeatureGate:SELinuxMountReadWriteOncePod] [Beta] [FeatureGate:SELinuxChangePolicy] [Beta] [Feature:SELinuxMountReadWriteOncePodOnly]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics Ephemeral should create volume metrics with the correct BlockMode PVC ref" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics PVC should create volume metrics in Volume Manager" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 Medium - "[sig-storage] [Serial] Volume metrics PVC should create volume metrics with the correct FilesystemMode PVC ref" is a new test, and was only seen in one job.

New tests seen in this PR at sha: c97ac81924a4d13f909ecf86e40cb8b7af1ff68d

  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] server supports sending resources in Table format" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by client-go's List method when WatchListClient is enabled" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] API Streaming (aka. WatchList) [FeatureGate:WatchList] [Beta] [Serial] should NOT be requested by metadata client's List method when WatchListClient is enabled" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-api-machinery] CBOR [Feature:CBOR] clients remain compatible with the 1.17 sample-apiserver [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-api-machinery] Namespaces [Serial] should always delete fast (ALL of 100 namespaces in 150 seconds) [Feature:ComprehensiveNamespaceDraining]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Daemon set [Serial] should not update pod when spec was updated and update strategy is OnDelete" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Daemon set [Serial] should surge pods onto nodes when spec was updated and update strategy is RollingUpdate" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] DisruptionController evictions: maxUnavailable deny evictions, integer => should not allow an eviction [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-apps] Job should run a job to completion with CPU requests [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] IngressClass [Feature:Ingress] should choose the one with the later CreationTimestamp, if equal the one with the lower name when two ingressClasses are marked as default [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] IngressClass [Feature:Ingress] should set default value on new IngressClass [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] Networking should allow creating a Pod with an SCTP HostPort [LinuxOnly] [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-network] Services should allow creating a basic SCTP service with pod and endpoints [LinuxOnly] [Serial]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-node] NoExecuteTaintManager Multiple Pods [Serial] only evicts pods without tolerations from tainted nodes" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] NoExecuteTaintManager Single Pod [Serial] pods evicted from tainted nodes have pod disruption condition" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] Pod Level Resources [Serial] [Feature:PodLevelResources] [FeatureGate:PodLevelResources] [Beta] Burstable QoS pod, 1 container with resources" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] Multi-AZ Clusters should spread the pods of a service across zones [Serial]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] PodTopologySpread Filtering validates 4 pods with MaxSkew=1 are evenly distributed into 2 nodes" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] validates local ephemeral storage resource limits of pods that are allowed to run" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • "[sig-scheduling] SchedulerPredicates [Serial] validates that taints-tolerations is respected if matching" [Total: 2, Pass: 2, Fail: 0, Flake: 0]
  • (...showing 20 of 31 tests)

openshift-trt[bot] avatar Nov 06 '25 14:11 openshift-trt[bot]

@sairameshv: This pull request references OCPNODE-3780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  • DynamicResourceAllocation feature has been graduated to GA
  • We need a few e2e tests defined downstream for this featuregate to be enabled to the Default cluster type
  • Added a test to validate the downstream specific code that depends on the DynamicResourceAllocation featuregate

Helps in promoting https://github.com/openshift/api/pull/2498

Tests generated by Claude

cc: @tkashem @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 04 '25 04:12 openshift-ci-robot

@sairameshv: This pull request references OCPNODE-3780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  • DynamicResourceAllocation feature has been graduated to GA upstream
  • These tests validate the v1alpha1, v1alpha2, v1beta1 APIs of DRA are disabled

Tests generated by Claude

cc: @tkashem @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 04 '25 04:12 openshift-ci-robot

/retest /jira refresh

sairameshv avatar Dec 04 '25 04:12 sairameshv

@sairameshv: This pull request references OCPNODE-3780 which is a valid jira issue.

In response to this:

/retest /jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 04 '25 04:12 openshift-ci-robot

/label acknowledge-critical-fixes-only

Adding the acknowledge-critical-fixes-only label as the API PR[1] has been merged and these tests are required to validate the undesired DRA's v1alpha1, v1alpha2, v1beta1 APIs

[1] - https://github.com/openshift/api/pull/2498

sairameshv avatar Dec 04 '25 05:12 sairameshv

@sairameshv, could you add a link to the log from the CI job above, along with a snippet showing that the test passed to the PR description?

ngopalak-redhat avatar Dec 04 '25 07:12 ngopalak-redhat

Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 50cc699ca0ef5d00850fc8e185378400dcf25c95

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 High - "[sig-node][DRA][OCPFeatureGate:DynamicResourceAllocation] Dynamic Resource Allocation should verify beta and alpha DRA APIs are disabled [apigroup:resource.k8s.io] [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 50cc699ca0ef5d00850fc8e185378400dcf25c95

  • "[sig-node][DRA][OCPFeatureGate:DynamicResourceAllocation] Dynamic Resource Allocation should verify beta and alpha DRA APIs are disabled [apigroup:resource.k8s.io] [Suite:openshift/conformance/parallel]" [Total: 3, Pass: 3, Fail: 0, Flake: 0]

openshift-trt[bot] avatar Dec 04 '25 09:12 openshift-trt[bot]

@sairameshv, could you add a link to the log from the CI job above, along with a snippet showing that the test passed to the PR description?

I think this is what you are referring to right @ngopalak-redhat ?

sairameshv avatar Dec 04 '25 12:12 sairameshv

Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi

openshift-ci-robot avatar Dec 10 '25 15:12 openshift-ci-robot

Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 76bcca7648e54ca4780b04e6bb63f1918b6643e8

  • "[sig-node][DRA][OCPFeatureGate:DynamicResourceAllocation] Dynamic Resource Allocation should verify beta and alpha DRA APIs are disabled [apigroup:resource.k8s.io] [Suite:openshift/conformance/parallel]" [Total: 5, Pass: 5, Fail: 0, Flake: 0]

openshift-trt[bot] avatar Dec 10 '25 20:12 openshift-trt[bot]

/verified by @sairameshv

sairameshv avatar Dec 11 '25 17:12 sairameshv

@sairameshv: This PR has been marked as verified by @sairameshv.

In response to this:

/verified by @sairameshv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Dec 11 '25 17:12 openshift-ci-robot

/lgtm

rphillips avatar Dec 11 '25 19:12 rphillips

/approve

smg247 avatar Dec 12 '25 10:12 smg247

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sairameshv, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 12 '25 10:12 openshift-ci[bot]

Scheduling required tests: /test e2e-aws-csi /test e2e-aws-ovn-fips /test e2e-aws-ovn-microshift /test e2e-aws-ovn-microshift-serial /test e2e-aws-ovn-serial-1of2 /test e2e-aws-ovn-serial-2of2 /test e2e-gcp-csi /test e2e-gcp-ovn /test e2e-gcp-ovn-upgrade /test e2e-metal-ipi-ovn-ipv6 /test e2e-vsphere-ovn /test e2e-vsphere-ovn-upi

openshift-ci-robot avatar Dec 12 '25 11:12 openshift-ci-robot