origin icon indicating copy to clipboard operation
origin copied to clipboard

Updated openshift-tests images to utilize mapped images from external binary

Open dinhxuanvu opened this issue 3 months ago • 20 comments

Currently, openshift-tests images cmd uses vendored GetMappedImageConfigs() function to map upstream images to mirrored ones. After this change, images cmd will parsed mapped images directly from outputs from the k8s-tests-ext binary. This prevents unexpected issues from imcompatible upstreams changes with vendored funcs.

dinhxuanvu avatar Sep 29 '25 23:09 dinhxuanvu

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Sep 29 '25 23:09 openshift-ci[bot]

/cc @bertinatto PTAL

dinhxuanvu avatar Sep 29 '25 23:09 dinhxuanvu

@dinhxuanvu: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @bertinatto PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 29 '25 23:09 openshift-ci[bot]

Together with openshift/kubernetes#2447, is this change getting us both original and mapped images?

Just in case you are not familiar with it, we can do that with this command:

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn openshift/kubernetes#2447

bertinatto avatar Sep 30 '25 18:09 bertinatto

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/02629160-9e28-11f0-963d-726455cb7bc7-0

openshift-ci[bot] avatar Sep 30 '25 18:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 10 '25 07:10 openshift-ci[bot]

Job Failure Risk Analysis for sha: a88fe103e7b589159f4a595ae3c975a2bdf537e4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests

openshift-trt[bot] avatar Oct 10 '25 12:10 openshift-trt[bot]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn openshift/kubernetes#2447

dinhxuanvu avatar Oct 10 '25 23:10 dinhxuanvu

@dinhxuanvu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9236830-a631-11f0-909f-cfa810781685-0

openshift-ci[bot] avatar Oct 10 '25 23:10 openshift-ci[bot]

/retest-required

dinhxuanvu avatar Oct 11 '25 23:10 dinhxuanvu

/test e2e-metal-ipi-ovn-ipv6

dinhxuanvu avatar Oct 13 '25 14:10 dinhxuanvu

Job Failure Risk Analysis for sha: 0913c4609f6ac8fa0069776f5807831daeb79e2b

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (142) are below the historical average (3147): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt[bot] avatar Oct 13 '25 20:10 openshift-trt[bot]

Job Failure Risk Analysis for sha: 52c391ee6af8134eae558321c519a5c5c0cf7201

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (142) are below the historical average (3183): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt[bot] avatar Oct 14 '25 04:10 openshift-trt[bot]

Job Failure Risk Analysis for sha: 6364e896a2d04b3afdc900a04c77f16fdd42d459

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (142) are below the historical average (3139): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt[bot] avatar Oct 14 '25 12:10 openshift-trt[bot]

@bertinatto Ready for another round of review. PTAL. Thanks.

dinhxuanvu avatar Nov 04 '25 17:11 dinhxuanvu

@dinhxuanvu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6364e896a2d04b3afdc900a04c77f16fdd42d459 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify 4d6ce8e63566fadfac88786548a5cb14718b06b4 link true /test verify
ci/prow/e2e-metal-ipi-ovn-ipv6 4d6ce8e63566fadfac88786548a5cb14718b06b4 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 18 '25 12:11 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Nov 18 '25 12:11 openshift-merge-robot

Job Failure Risk Analysis for sha: 4d6ce8e63566fadfac88786548a5cb14718b06b4

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (3) are below the historical average (2444): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt[bot] avatar Nov 18 '25 13:11 openshift-trt[bot]

/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn openshift/kubernetes#2447

bertinatto avatar Nov 24 '25 16:11 bertinatto

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29a7cf10-c952-11f0-8f49-cbdc43e1a601-0

openshift-ci[bot] avatar Nov 24 '25 16:11 openshift-ci[bot]