origin icon indicating copy to clipboard operation
origin copied to clipboard

add a monitor test to ensure AlwaysAllow policy on PDBs

Open atiratree opened this issue 1 year ago • 10 comments

atiratree avatar Aug 27 '24 09:08 atiratree

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jan 01 '25 01:01 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jan 31 '25 08:01 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Mar 31 '25 00:03 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Mar 31 '25 00:03 openshift-ci[bot]

/reopen /remove-lifecycle stale

this should be revisited

atiratree avatar Apr 01 '25 19:04 atiratree

/remove-lifecycle rotten

atiratree avatar Apr 01 '25 19:04 atiratree

@atiratree: Reopened this PR.

In response to this:

/reopen /remove-lifecycle stale

this should be revisited

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Apr 01 '25 19:04 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 01 '25 19:04 openshift-ci[bot]

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-aws-ovn-ipsec-serial
ci/prow/e2e-gcp-ovn-builds 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-azure-ovn-etcd-scaling 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-agnostic-ovn-cmd 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-vsphere-ovn-etcd-scaling 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-openstack-ovn 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-openstack-ovn
ci/prow/okd-e2e-gcp 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test okd-e2e-gcp
ci/prow/e2e-aws-ovn-etcd-scaling 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-disruptive 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-gcp-disruptive
ci/prow/e2e-gcp-ovn-etcd-scaling 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-fips-serial 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-gcp-fips-serial
ci/prow/e2e-openstack-serial 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-openstack-serial
ci/prow/e2e-azure 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-azure
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-azure-ovn-upgrade 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test e2e-azure-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial-2of2 997d9e9bd62f43594a3de6c6bad52e129023d2d1 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar May 02 '25 23:05 openshift-ci[bot]

Job Failure Risk Analysis for sha: 997d9e9bd62f43594a3de6c6bad52e129023d2d1

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (24) are below the historical average (1080): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

Risk analysis has seen new tests most likely introduced by this PR. Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 997d9e9bd62f43594a3de6c6bad52e129023d2d1

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy cleanup" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy collection" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy interval construction" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy setup" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy test evaluation" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy writing to storage" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-apiserver should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-apiserver-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-authentication should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-authentication-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-catalogd should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-controller-manager should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-controller-manager-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-credential-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-network-config-controller should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-platform-infra should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-csi-drivers should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-machine-approver should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
pull-ci-openshift-origin-main-e2e-aws-ovn-edge-zones High - "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-node-tuning-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" is a new test that was not present in all runs against the current commit.
(...showing 20 of 306 rows)

New tests seen in this PR at sha: 997d9e9bd62f43594a3de6c6bad52e129023d2d1

  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy cleanup" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy collection" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy interval construction" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy setup" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy test evaluation" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[Jira:"Cluster Version Operator"] monitor test pdb-unhealthy-pod-eviction-policy writing to storage" [Total: 55, Pass: 55, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-apiserver should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-apiserver-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-authentication should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-authentication-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-catalogd should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 51, Pass: 51, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-controller-manager should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 36]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-controller-manager-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 51, Pass: 51, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-credential-operator should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 24]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-network-config-controller should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cloud-platform-infra should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 51, Pass: 51, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-api should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-csi-drivers should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 14]
  • "[sig-apps] all PodDisruptionBudgets in ns/openshift-cluster-machine-approver should have a "AlwaysAllow" .spec.unhealthyPodEvictionPolicy" [Total: 52, Pass: 52, Fail: 0, Flake: 0]
  • (...showing 20 of 80 tests)

openshift-trt[bot] avatar May 03 '25 00:05 openshift-trt[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 02 '25 01:08 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Sep 01 '25 08:09 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Oct 02 '25 00:10 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 02 '25 00:10 openshift-ci[bot]