origin icon indicating copy to clipboard operation
origin copied to clipboard

MON-3775: [WIP] add tests for CMO collection profiles

Open rexagod opened this issue 1 year ago • 7 comments

The tests cover the following cases:

  • Apply every collection profile, and check if the expected ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava [email protected]

rexagod avatar May 05 '24 18:05 rexagod

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if appropriate metrics are available (or unavailable).
  • CMO configuration reconciliation after a collection profile is applied is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 05 '24 18:05 openshift-ci-robot

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar May 05 '24 18:05 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 05 '24 18:05 openshift-ci[bot]

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

The tests cover the following cases:

  • Apply every collection profile, and check if the expected ServiceMonitors are available.
  • CMO configuration reconciliation after a collection profile is applied is checked within the CMO tests itself.
  • Prometheus *monitor selectors' reconciliation after a collection profile is applied is checked within the CMO tests itself.

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 05 '24 18:05 openshift-ci-robot

Job Failure Risk Analysis for sha: e449b028a2720f5dee62e4f8a4e265a609ad02ed

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial High
[sig-network-edge][Feature:Idling] Unidling [apigroup:apps.openshift.io][apigroup:route.openshift.io] should handle many TCP connections by possibly dropping those over a certain bound [Serial] [Suite:openshift/conformance/serial]
This test has passed 98.57% of 70 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-single-node-serial' 'periodic-ci-openshift-release-master-nightly-4.16-e2e-aws-ovn-single-node-serial'] in the last 14 days.

openshift-trt-bot avatar May 08 '24 01:05 openshift-trt-bot

/hold

rexagod avatar May 28 '24 08:05 rexagod

/retest

rexagod avatar May 28 '24 10:05 rexagod

Job Failure Risk Analysis for sha: c1c120cd808f4e0e2165b765b22a198662017dde

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (98) are below the historical average (576): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar May 28 '24 12:05 openshift-trt-bot

Job Failure Risk Analysis for sha: 2e366ac71f1f07198fba73605862467f968242e2

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.79% of 4728 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial IncompleteTests
Tests for this run (98) are below the historical average (564): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar May 28 '24 16:05 openshift-trt-bot

Job Failure Risk Analysis for sha: b63701457bad2f957a8862f6a8907e47efaab42d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-devex] check registry.redhat.io is available and samples operator can import sample imagestreams run sample related validations [apigroup:config.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/parallel]
This test has passed 99.05% of 2327 runs on release 4.17 [Overall] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.78% of 4630 runs on release 4.17 [Overall] in the last week.
---
[sig-arch] events should not repeat pathologically for ns/openshift-kube-apiserver-operator
This test has passed 99.74% of 4618 runs on release 4.17 [Overall] in the last week.
---
[sig-arch] Only known images used by tests
This test has passed 99.81% of 4630 runs on release 4.17 [Overall] in the last week.

openshift-trt-bot avatar May 29 '24 10:05 openshift-trt-bot

Job Failure Risk Analysis for sha: a0a9fc1e32727c1de46cd72903abefb1509d6276

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-cluster-lifecycle] pathological event should not see excessive Back-off restarting failed containers for ns/openshift-marketplace
This test has passed 99.89% of 4576 runs on release 4.17 [Overall] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.89% of 4576 runs on release 4.17 [Overall] in the last week.

openshift-trt-bot avatar May 29 '24 21:05 openshift-trt-bot

Job Failure Risk Analysis for sha: 62cbbbbc0e9bc96037608debe9398e0c9ab86604

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 99.92% of 4719 runs on release 4.17 [Overall] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.98% of 4730 runs on release 4.17 [Overall] in the last week.

openshift-trt-bot avatar May 30 '24 12:05 openshift-trt-bot

Job Failure Risk Analysis for sha: 060391d4ac585e6b0b03555d54ffc829132e8bee

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade High
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 99.98% of 4946 runs on release 4.17 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones IncompleteTests
Tests for this run (102) are below the historical average (2015): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar May 30 '24 19:05 openshift-trt-bot

/pj-rehearse periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-techpreview

rexagod avatar Jun 01 '24 08:06 rexagod

/test e2e-gcp-ovn-techpreview

rexagod avatar Jun 01 '24 08:06 rexagod

/hold cancel

rexagod avatar Jun 02 '24 05:06 rexagod

/test e2e-gcp-ovn-techpreview

rexagod avatar Jun 02 '24 13:06 rexagod

Job Failure Risk Analysis for sha: 2b6dd3bd6866e840398c345c43424fd3985aa34d

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial High
[sig-arch] events should not repeat pathologically for ns/openshift-dns
This test has passed 100.00% of 48 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.
---
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 100.00% of 48 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade Low
[bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.

Open Bugs
openshift-apiserver ClusterOperator should not blip Available=False on brief missing HTTP content-type
---
[bz-Storage] clusteroperator/storage should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-Node Tuning Operator] clusteroperator/node-tuning should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
[bz-Storage] clusteroperator/csi-snapshot-controller should not change condition/Available
This test has passed 0.00% of 1 runs on release 4.17 [amd64 aws ovn single-node upgrade upgrade-micro] in the last week.
---
Showing 4 of 6 test results

openshift-trt-bot avatar Jun 02 '24 18:06 openshift-trt-bot

Job Failure Risk Analysis for sha: ac235e155483cbfbe438aa820c346a3beeb6e6e5

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial High
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 100.00% of 48 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.

openshift-trt-bot avatar Jun 03 '24 02:06 openshift-trt-bot

/retest-required /test e2e-gcp-ovn-techpreview

rexagod avatar Jun 03 '24 03:06 rexagod

/test help

rexagod avatar Jun 03 '24 04:06 rexagod

@rexagod: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-ipsec-serial
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-azure-ovn-upgrade
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 03 '24 04:06 openshift-ci[bot]

/test e2e-gcp-ovn-techpreview-serial

rexagod avatar Jun 03 '24 04:06 rexagod

@rexagod: This pull request references MON-3775 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Refer: openshift/enhancements#1298

Signed-off-by: Pranshu Srivastava [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 03 '24 07:06 openshift-ci-robot

/test e2e-gcp-ovn-techpreview

rexagod avatar Jun 03 '24 07:06 rexagod

/retitle MON-3775: [WIP] add tests for CMO collection profiles

Ping @simonpasquier, this should be ready for review once I resolve the CI.

rexagod avatar Jun 03 '24 12:06 rexagod

/assign @simonpasquier

rexagod avatar Jun 03 '24 12:06 rexagod

Job Failure Risk Analysis for sha: dba0cc9d27ef5ddbf84ed240d5f4d87c94401dac

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial High
[sig-arch] events should not repeat pathologically for ns/openshift-authentication-operator
This test has passed 100.00% of 52 runs on jobs ['periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (18) are below the historical average (1599): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn IncompleteTests
Tests for this run (18) are below the historical average (1800): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Jun 03 '24 14:06 openshift-trt-bot

/test verify

┌[rexagod@nebuchadnezzar] [/dev/ttys005] [3775 ⚡]
└[~/repositories/work/origin]> ./hack/verify-generated.sh
SUCCESS after 31.000s: hack/verify-generated.sh:13: executing '/Users/rexagod/repositories/work/origin/hack/update-generated.sh' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:14: executing 'git diff --exit-code /Users/rexagod/repositories/work/origin/test/extended/util/annotate/generated/' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:15: executing 'git diff --exit-code /Users/rexagod/repositories/work/origin/test/extended/util/image/zz_generated.txt' expecting success
SUCCESS after 0.000s: hack/verify-generated.sh:16: executing 'git diff --exit-code /Users/rexagod/repositories/work/origin/zz_generated.manifests' expecting success
[INFO] hack/verify-generated.sh exited with code 0 after 00h 00m 32s

The CI logs show failure for the job, but it's passing on my local, with the same go version as the project's. I'll jump on the proposed additions once this goes green again.

rexagod avatar Jun 05 '24 14:06 rexagod

@rexagod: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-ipsec-serial
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-azure-ovn-upgrade
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-dualstack-local-gateway
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-dualstack-primaryv6
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 05 '24 14:06 openshift-ci[bot]