origin
origin copied to clipboard
OCPBUGS-29614: Skip CPMS tests on clusters without it
We had originally tried to detect UPI cluster by presence of an infrastructure resource but looks like that's actually there. The best way to skip this just seems to be based on whether or not there's a CPMS at all.
/test
@stbenjam: The /test command needs one or more targets.
The following commands are available to trigger required jobs:
/test e2e-aws-jenkins/test e2e-aws-ovn-fips/test e2e-aws-ovn-image-registry/test e2e-aws-ovn-serial/test e2e-gcp-ovn/test e2e-gcp-ovn-builds/test e2e-gcp-ovn-image-ecosystem/test e2e-gcp-ovn-upgrade/test e2e-metal-ipi-ovn-ipv6/test images/test lint/test unit/test verify/test verify-deps
The following commands are available to trigger optional jobs:
/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback/test e2e-agnostic-ovn-cmd/test e2e-aws/test e2e-aws-csi/test e2e-aws-disruptive/test e2e-aws-etcd-recovery/test e2e-aws-multitenant/test e2e-aws-ovn/test e2e-aws-ovn-cgroupsv2/test e2e-aws-ovn-etcd-scaling/test e2e-aws-ovn-kubevirt/test e2e-aws-ovn-single-node/test e2e-aws-ovn-single-node-serial/test e2e-aws-ovn-single-node-upgrade/test e2e-aws-ovn-upgrade/test e2e-aws-ovn-upi/test e2e-aws-proxy/test e2e-azure/test e2e-azure-ovn-etcd-scaling/test e2e-baremetalds-kubevirt/test e2e-gcp-csi/test e2e-gcp-disruptive/test e2e-gcp-fips-serial/test e2e-gcp-ovn-etcd-scaling/test e2e-gcp-ovn-rt-upgrade/test e2e-gcp-ovn-techpreview/test e2e-gcp-ovn-techpreview-serial/test e2e-metal-ipi-ovn-dualstack/test e2e-metal-ipi-sdn/test e2e-metal-ipi-serial/test e2e-metal-ipi-serial-ovn-ipv6/test e2e-metal-ipi-virtualmedia/test e2e-openstack-ovn/test e2e-openstack-serial/test e2e-vsphere/test e2e-vsphere-ovn-dualstack-primaryv6/test e2e-vsphere-ovn-etcd-scaling/test okd-e2e-gcp
Use /test all to run the following jobs that were automatically triggered:
pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmdpull-ci-openshift-origin-master-e2e-aws-csipull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2pull-ci-openshift-origin-master-e2e-aws-ovn-fipspull-ci-openshift-origin-master-e2e-aws-ovn-serialpull-ci-openshift-origin-master-e2e-aws-ovn-single-nodepull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serialpull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgradepull-ci-openshift-origin-master-e2e-aws-ovn-upgradepull-ci-openshift-origin-master-e2e-gcp-csipull-ci-openshift-origin-master-e2e-gcp-ovnpull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgradepull-ci-openshift-origin-master-e2e-gcp-ovn-upgradepull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6pull-ci-openshift-origin-master-e2e-metal-ipi-sdnpull-ci-openshift-origin-master-e2e-openstack-ovnpull-ci-openshift-origin-master-imagespull-ci-openshift-origin-master-lintpull-ci-openshift-origin-master-unitpull-ci-openshift-origin-master-verifypull-ci-openshift-origin-master-verify-deps
In response to this:
/test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/test e2e-aws-ovn-upi
/test e2e-aws-ovn-upi
Looks like UPI clusters actually do have an infrastructure resource.
/test e2e-aws-ovn-upi
@stbenjam: This pull request references Jira Issue OCPBUGS-29614, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @huali9
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
We had originally tried to detect UPI cluster by presence of an infrastructure resource but looks like that's actually there. The best way to skip this just seems to be based on whether or not there's at CPMS at all.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: neisw, stbenjam
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~test/OWNERS~~ [neisw,stbenjam]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
i think this will definitely work in the situation we are looking at, but i have also proposed https://github.com/openshift/origin/pull/28625 which is a more systemic fix of the skipUnlessMachineAPIOperator function which is used in other CPMS tests.
adding a hold just so we can discuss the other fix
/hold
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-29614, which is invalid:
- expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
i think this is something we want to do, not sure where we got hung up
/remove-lifecycle rotten
ok, so it seems my other fix got merged, so maybe we don't need this. @stbenjam any thoughts? should we just close this?
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-metal-ipi-sdn | 32c23c3502ff782ac213176938190804b3716fa0 | link | false | /test e2e-metal-ipi-sdn |
| ci/prow/e2e-openstack-ovn | 32c23c3502ff782ac213176938190804b3716fa0 | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 32c23c3502ff782ac213176938190804b3716fa0 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-ovn-single-node | 32c23c3502ff782ac213176938190804b3716fa0 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-ovn-single-node-serial | 32c23c3502ff782ac213176938190804b3716fa0 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-gcp-ovn-builds | 32c23c3502ff782ac213176938190804b3716fa0 | link | true | /test e2e-gcp-ovn-builds |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 32c23c3502ff782ac213176938190804b3716fa0 | link | true | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-vsphere-ovn-upi | 32c23c3502ff782ac213176938190804b3716fa0 | link | true | /test e2e-vsphere-ovn-upi |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@stbenjam: This pull request references Jira Issue OCPBUGS-29614. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
We had originally tried to detect UPI cluster by presence of an infrastructure resource but looks like that's actually there. The best way to skip this just seems to be based on whether or not there's a CPMS at all.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.