origin
origin copied to clipboard
openshift
TRT-1506: Restore the tests looking for excess single-second disruptions
These were mistakenly broken in the 4.14 release timeframe during the monitortest refactor. The format of disruption intervals changed and the way this test was looking for backend names was then broken. I've modified the code to now better detect all disruption backends, pick the ones we want to run these tests on (ingress and api backends), and fixed the ordering of the case logic which was inverted and the > 50 check could never run, because the > 20 would match first.
Dev command for running invariants against an intervals file is partially restored, for these tests only.
./openshift-tests dev run-disruption-invariants --intervals-file e2e-timelines_spyglass_20240209-082358.json
Bringing back as they will help us hunt for spatter disruption on gcp jobs.
@dgoodwin: This pull request references TRT-1506 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.
In response to this:
These were mistakenly broken in the 4.14 release timeframe during the monitortest refactor. The format of disruption intervals changed and the way this test was looking for backend names was then broken. I've modified the code to now better detect all disruption backends, pick the ones we want to run these tests on (ingress and api backends), and fixed the ordering of the case logic which was inverted and the > 50 check could never run, because the > 20 would match first.
Dev command for running invariants against an intervals file is partially restored, for these tests only.
./openshift-tests dev run-disruption-invariants --intervals-file e2e-timelines_spyglass_20240209-082358.jsonBringing back as they will help us hunt for spatter disruption on gcp jobs.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dgoodwin, xueqzhan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~pkg/OWNERS~~ [dgoodwin,xueqzhan]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
/retest-required
Remaining retests: 0 against base HEAD ddc4a1c510022a2a6fb31799e70c9007a66c4093 and 2 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 7df4d94214010de82b01208c9caddfc7a276cae8 and 1 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 7812f3cbbadfff5e7570f48b2dce3331ab24b729 and 0 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/hold
Revision bba155934e1cc4e455b96f54a39c6c53ad62facb was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 7812f3cbbadfff5e7570f48b2dce3331ab24b729 and 2 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD bd2ae41805349538f0e221d6f73c4ad354837121 and 1 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 28433a19e2609dd1f43afec9b06410a54f4d4c8e and 0 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/hold
Revision bba155934e1cc4e455b96f54a39c6c53ad62facb was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 2c9f3ffe4cce39d59c8d00008889f2a037a91124 and 2 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 44e37715525db8134e902e55079dda2613e6096d and 1 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 93d6a84ccac34608e2f7ef425f5dc4ef7b948e6e and 0 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/hold
Revision bba155934e1cc4e455b96f54a39c6c53ad62facb was retested 3 times: holding
/retest-required
Remaining retests: 0 against base HEAD 9c9713ed8c98e88b089ebca8ee5b7c1bba7423d2 and 2 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
/retest-required
Remaining retests: 0 against base HEAD 96d2578c1d54c9d1091f37746abb2858d2b876d9 and 1 for PR HEAD bba155934e1cc4e455b96f54a39c6c53ad62facb in total
@dgoodwin: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202402262210.p0.gf5e7c35.assembly.stream.el8 for distgit openshift-enterprise-tests. All builds following this will include this PR.
