origin icon indicating copy to clipboard operation
origin copied to clipboard

Ignore an error intentionally generated by a test case

Open danwinship opened this issue 1 year ago • 8 comments

There's a statefulset test that does:

  • create a pod that binds hostport 21017
  • create a StatefulSet that also binds that hostport
  • ensure that the StatefulSet can't be deployed to the node with the pod from the first step
  • kill the conflicting pod
  • ensure that the StatefulSet now gets deployed to that node

The problem is that apparently it's possible for the new StatefulSet pod to get deployed before the conflicting pod is fully cleaned up, in which case the first attempt at CreatePodSandBox will fail because it can't bind the hostport, but then the second attempt a bit later will succeed, and the e2e test doesn't even notice anything unusual happened. But openshift-tests notices the CreatePodSandBox failure and complains (eg, https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2262/pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6/1756963861908426752)

This fixes us to ignore that specific event. (I also added a new categorization for "pods should successfully create sandboxes" errors.)

danwinship avatar Feb 12 '24 21:02 danwinship

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danwinship Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 12 '24 21:02 openshift-ci[bot]

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 64b9e492e9e7288528f678b14317864a9b240800 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-csi 64b9e492e9e7288528f678b14317864a9b240800 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-single-node-serial 64b9e492e9e7288528f678b14317864a9b240800 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 64b9e492e9e7288528f678b14317864a9b240800 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Feb 13 '24 00:02 openshift-ci[bot]

/assign @stbenjam

danwinship avatar Mar 01 '24 13:03 danwinship

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar May 31 '24 01:05 openshift-bot

/remove-lifecycle stale

danwinship avatar May 31 '24 10:05 danwinship