origin icon indicating copy to clipboard operation
origin copied to clipboard

OCPBUGS-26603: e2e: fix malformed IPv6 URLs, use brackets

Open rbbratta opened this issue 1 year ago • 41 comments

Fixes for pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack-primaryv6

Grep all the e2e logs with the malformed IPv6 regex

rg  -o '.{0,20}https?://(([0-9a-fA-F]{1,4}:){7,7}[0-9a-fA-F]{1,4}|([0-9a-fA-F]{1,4}:){1,7}:|([0-9a-fA-F]{1,4}:){1,6}:[0-9a-fA-F]{1,4}|([0-9a-fA-F]{1,4}:){1,5}(:[0-9a-fA-F]{1,4}){1,2}|([0-9a-fA-F]{1,4}:){1,4}(:[0-9a-fA-F]{1,4}){1,3}|([0-9a-fA-F]{1,4}:){1,3}(:[0-9a-fA-F]{1,4}){1,4}|([0-9a-fA-F]{1,4}:){1,2}(:[0-9a-fA-F]{1,4}){1,5}|[0-9a-fA-F]{1,4}:((:[0-9a-fA-F]{1,4}){1,6})|:((:[0-9a-fA-F]{1,4}){1,7}|:)|fe80:(:[0-9a-fA-F]{0,4}){0,4}%[0-9a-zA-Z]{1,}|::(ffff(:0{1,4}){0,1}:){0,1}((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}(25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])|([0-9a-fA-F]{1,4}:){1,4}:((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}(25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])).{0,20}'
 FIRST.example.com' http://fd65:10:128:3::331/Letter\n+ code=0
 FIRST.example.com' http://fd65:10:128:3::334/Letter\n+ code=0
4ck.apps.veto.test' http://fd65:10:128:4::41b/Letter\n+ code=0
FIRST.example.com' "http://fd65:10:128:3::331/Letter" ) || rc=
FIRST.example.com' "http://fd65:10:128:3::334/Letter" ) || rc=
apps.mycompany.com' http://fd65:10:128:3::2e1/Letter\n+ code=0
ck.apps.veto.test' "http://fd65:10:128:4::41b/Letter" ) || rc=
pps.mycompany.com' "http://fd65:10:128:3::2e1/Letter" ) || rc=
ster.openshift.com' http://fd65:a1a8:60ad:1207::a\n+ code=000\n+ rc=
ster.openshift.com' https://fd65:172:16::2837\n+ code=000\n+
ter.openshift.com' "http://fd65:a1a8:60ad:1207::a" ) || rc=$?
ter.openshift.com' "https://fd65:172:16::2837" ) || rc=$?

rbbratta avatar Feb 07 '24 18:02 rbbratta

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbbratta Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Feb 07 '24 18:02 openshift-ci[bot]

@jluhrsen PTAL

rbbratta avatar Feb 07 '24 18:02 rbbratta

/retitle e2e: fix malformed IPv6 URLs, use brackets

rbbratta avatar Feb 08 '24 00:02 rbbratta

/test ci/prow/e2e-vsphere-ovn-dualstack-primaryv6

jluhrsen avatar Feb 08 '24 01:02 jluhrsen

@jluhrsen: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ci/prow/e2e-vsphere-ovn-dualstack-primaryv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 08 '24 01:02 openshift-ci[bot]

/test e2e-vsphere-ovn-dualstack-primaryv6

jluhrsen avatar Feb 08 '24 01:02 jluhrsen

@jluhrsen: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-jenkins
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-image-registry
  • /test e2e-aws-ovn-serial
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-builds
  • /test e2e-gcp-ovn-image-ecosystem
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6
  • /test images
  • /test lint
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
  • /test e2e-agnostic-ovn-cmd
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-etcd-recovery
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-cgroupsv2
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-kubevirt
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-single-node-serial
  • /test e2e-aws-ovn-single-node-upgrade
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-upi
  • /test e2e-aws-proxy
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-baremetalds-kubevirt
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-techpreview-serial
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack-ovn
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-ovn-fips
  • pull-ci-openshift-origin-master-e2e-aws-ovn-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
  • pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-origin-master-e2e-openstack-ovn
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-lint
  • pull-ci-openshift-origin-master-unit
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test e2e-vsphere-ovn-dualstack-primaryv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 08 '24 01:02 openshift-ci[bot]

/test e2e-metal-ipi-ovn-dualstack

jluhrsen avatar Feb 08 '24 01:02 jluhrsen

if we get this release PR merged we can trigger the dualstack-primartyv6 job on this PR with a comment.

jluhrsen avatar Feb 08 '24 01:02 jluhrsen

  curl --http1.1 -X GET --connect-to ::"fd65:172:16::c722"   -s -S -o /tmp/body -D /tmp/headers "https://www.google.com" -w '{"code":%{http_code}}' -k 2>/tmp/error 1>/tmp/output || rc=$?

also incorrect, needs brackets.

rbbratta avatar Feb 08 '24 17:02 rbbratta

We have to be careful with double-bracketing maybe. There is no good way to sanitize URI by parsing and unparsing. Golang net/url.URL won't sanitize, it requires net.JoinHostPort() which doesn't work without a port. Stupid stdlib design.

rbbratta avatar Feb 08 '24 17:02 rbbratta

@stbenjam PTAL

rbbratta avatar Feb 08 '24 17:02 rbbratta

Some tests still fail.

[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router should override the route host with a custom value [Skipped:Disconnected] [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router should run even if it has no access to update status [apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router should serve the correct routes when scoped to a single namespace and label set [Skipped:Disconnected] [Suite:openshift/conformance/parallel]
[sig-network][Feature:Router][apigroup:route.openshift.io][apigroup:operator.openshift.io] The HAProxy router should support reencrypt to services backed by a serving certificate automatically [Skipped:Disconnected] [Suite:openshift/conformance/parallel]

https://file.rdu.redhat.com/~rbrattai/logs/haproxy-junit-2024-02-08-130254.tar.zst

rbbratta avatar Feb 08 '24 18:02 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

jluhrsen avatar Feb 08 '24 20:02 jluhrsen

/test e2e-vsphere-ovn-dualstack-primaryv6

jluhrsen avatar Feb 08 '24 23:02 jluhrsen

/test e2e-vsphere-ovn-dualstack-primaryv6

jluhrsen avatar Feb 09 '24 01:02 jluhrsen

/test e2e-vsphere-ovn-dualstack-primaryv6

I haven't dug in to theses results, but 3 times in a row now the cluster didn't install

jluhrsen avatar Feb 09 '24 06:02 jluhrsen

/retitle OCPBUGS-26603: e2e: fix malformed IPv6 URLs, use brackets

rbbratta avatar Feb 13 '24 22:02 rbbratta

@rbbratta: This pull request references Jira Issue OCPBUGS-26603, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes for pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack-primaryv6

Grep all the e2e logs with the malformed IPv6 regex

rg  -o '.{0,20}https?://(([0-9a-fA-F]{1,4}:){7,7}[0-9a-fA-F]{1,4}|([0-9a-fA-F]{1,4}:){1,7}:|([0-9a-fA-F]{1,4}:){1,6}:[0-9a-fA-F]{1,4}|([0-9a-fA-F]{1,4}:){1,5}(:[0-9a-fA-F]{1,4}){1,2}|([0-9a-fA-F]{1,4}:){1,4}(:[0-9a-fA-F]{1,4}){1,3}|([0-9a-fA-F]{1,4}:){1,3}(:[0-9a-fA-F]{1,4}){1,4}|([0-9a-fA-F]{1,4}:){1,2}(:[0-9a-fA-F]{1,4}){1,5}|[0-9a-fA-F]{1,4}:((:[0-9a-fA-F]{1,4}){1,6})|:((:[0-9a-fA-F]{1,4}){1,7}|:)|fe80:(:[0-9a-fA-F]{0,4}){0,4}%[0-9a-zA-Z]{1,}|::(ffff(:0{1,4}){0,1}:){0,1}((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}(25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])|([0-9a-fA-F]{1,4}:){1,4}:((25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])\.){3,3}(25[0-5]|(2[0-4]|1{0,1}[0-9]){0,1}[0-9])).{0,20}'
FIRST.example.com' http://fd65:10:128:3::331/Letter\n+ code=0
FIRST.example.com' http://fd65:10:128:3::334/Letter\n+ code=0
4ck.apps.veto.test' http://fd65:10:128:4::41b/Letter\n+ code=0
FIRST.example.com' "http://fd65:10:128:3::331/Letter" ) || rc=
FIRST.example.com' "http://fd65:10:128:3::334/Letter" ) || rc=
apps.mycompany.com' http://fd65:10:128:3::2e1/Letter\n+ code=0
ck.apps.veto.test' "http://fd65:10:128:4::41b/Letter" ) || rc=
pps.mycompany.com' "http://fd65:10:128:3::2e1/Letter" ) || rc=
ster.openshift.com' http://fd65:a1a8:60ad:1207::a\n+ code=000\n+ rc=
ster.openshift.com' https://fd65:172:16::2837\n+ code=000\n+
ter.openshift.com' "http://fd65:a1a8:60ad:1207::a" ) || rc=$?
ter.openshift.com' "https://fd65:172:16::2837" ) || rc=$?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 13 '24 22:02 openshift-ci-robot

/test e2e-vsphere-ovn-dualstack-primaryv6

It seems like what fails is a bunch of random and unrelated conformance tests ¯_(ツ)_/¯

mkowalski avatar Feb 15 '24 08:02 mkowalski

openshift cluster install failed with cluster bootstrap on latest.

rbbratta avatar Feb 15 '24 17:02 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

mkowalski avatar Feb 21 '24 08:02 mkowalski

/retest-required

rbbratta avatar Feb 26 '24 12:02 rbbratta

/retest-required

rbbratta avatar Mar 04 '24 09:03 rbbratta

Job Failure Risk Analysis for sha: bddec446fb3708bce8dab31b115c0dcf73bbe34e

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (799) are below the historical average (2017): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-vsphere-ovn-dualstack-primaryv6 Medium
[sig-sippy] infrastructure should work
This test has passed 94.74% of 19 runs on release 4.16 [amd64 ha ovn vsphere-ipi] in the last week.
---
install should succeed: cluster bootstrap
This test has passed 94.44% of 18 runs on release 4.16 [amd64 ha ovn vsphere-ipi] in the last week.

openshift-trt-bot avatar Mar 05 '24 16:03 openshift-trt-bot

@rfredette PTAL

rbbratta avatar Mar 11 '24 17:03 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

rbbratta avatar Mar 12 '24 17:03 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

rbbratta avatar Mar 13 '24 00:03 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

rbbratta avatar Mar 13 '24 04:03 rbbratta

/test e2e-vsphere-ovn-dualstack-primaryv6

rbbratta avatar Mar 13 '24 13:03 rbbratta