origin icon indicating copy to clipboard operation
origin copied to clipboard

update generators to handle ondisk resources

Open deads2k opened this issue 1 year ago • 4 comments

generator isn't yet using the on-disk certificates. Types are missing from library-go

deads2k avatar Jan 22 '24 14:01 deads2k

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 22 '24 14:01 openshift-ci[bot]

/hold

really want to remove the on-disk revisions.

deads2k avatar Jan 22 '24 15:01 deads2k

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node-serial b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/verify-deps b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600 link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 25 '24 02:01 openshift-ci[bot]

Job Failure Risk Analysis for sha: b22e4ae0a5e62b465e6f5e9ce8bad6ee28ab9600

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (419) are below the historical average (2017): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Mar 05 '24 16:03 openshift-trt-bot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 04 '24 01:06 openshift-bot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot avatar Jun 04 '24 01:06 openshift-merge-robot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jul 04 '24 08:07 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Aug 04 '24 00:08 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 04 '24 00:08 openshift-ci[bot]