origin icon indicating copy to clipboard operation
origin copied to clipboard

demonstrate problem generating docs

Open deads2k opened this issue 1 year ago • 5 comments

In https://github.com/openshift/library-go/pull/1592 I indicated that it would cause problems for generating documentation. I've had to update the chain guessing to be good enough to even see which problems we have, but have a look at https://github.com/openshift/api/tree/master/tls/docs/kube-apiserver%20Serving%20Certificates#kube-apiserver-localhost-signer . It used to have a description. We cannot use the description off of the in-cluster and on-disk locations because those are targeted for "what is this instance using it for", but we need an overall description to describe the thing.

To my knowledge, no replacement for this lost functionality was created, so we have a gap across dozens of these certificates. How will we solve that?

/assign @vrutkovs

deads2k avatar Jan 08 '24 22:01 deads2k

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k Once this PR has been reviewed and has the lgtm label, please assign dennisperiquet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Jan 15 '24 21:01 openshift-ci[bot]

unit tests added. A couple bugs fixed. But now won't complete without public key modulus in the raw tls files, so I really want that soon.

deads2k avatar Jan 15 '24 21:01 deads2k

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Jan 17 '24 09:01 openshift-merge-robot

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-image-registry aaf15b78f90a5110ef1022c5272c0cef138e0c64 link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-gcp-ovn-builds aaf15b78f90a5110ef1022c5272c0cef138e0c64 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-single-node 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-metal-ipi-sdn 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link false /test e2e-aws-ovn-single-node-serial
ci/prow/verify 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test verify
ci/prow/e2e-aws-ovn-serial 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn-upgrade 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/unit 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test unit
ci/prow/lint 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test lint
ci/prow/e2e-aws-ovn-fips 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test e2e-aws-ovn-fips
ci/prow/verify-deps 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test verify-deps
ci/prow/e2e-gcp-ovn 8d903442063d5af71ad2a0ac43c78a586b2c40f4 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jan 18 '24 03:01 openshift-ci[bot]

Job Failure Risk Analysis for sha: 8d903442063d5af71ad2a0ac43c78a586b2c40f4

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade IncompleteTests
Tests for this run (419) are below the historical average (2017): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node IncompleteTests
Tests for this run (25) are below the historical average (1607): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-trt-bot avatar Mar 05 '24 16:03 openshift-trt-bot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 04 '24 01:06 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Jul 04 '24 08:07 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Aug 04 '24 00:08 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Aug 04 '24 00:08 openshift-ci[bot]