origin
origin copied to clipboard
openshift
USHIFT-1858 USHIFT-1866: use public images in router scoped+unprivileged tests
Adaptations so that these tests are able to run in MicroShift, which does not have a local image registry from where to pull the Shell image. It replaces that with agnhost, which is available in public registries.
@pacevedom: This pull request references USHIFT-1866 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.
In response to this:
Adaptations so that these tests are able to run in MicroShift, which does not have a local image registry from where to pull the Shell image. It replaces that with agnhost, which is available in public registries.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pacevedom Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
A lot of tests use ShellImage, wouldn't it be better to make this work on microshift (somehow)? It's available in the Red Hat registry I think https://catalog.redhat.com/software/containers/openshift4/ose-tools-rhel8/5f748d3399cc5b9e7c1a8747?architecture=amd64&image=654d55b19bad3d62eaba06ce&container-tabs=overview
Maybe it be possible to use an ICSP to route the cli and tools images to a public registry on Microshift?
https://github.com/openshift/origin/blob/acfaf0a446cc3d5dfff2a68adbcde5d5678df31c/test/extended/util/image/image.go#L26-L29
test/extended/util/image/README.md reccomends this is the default image folks use, so I could see this being a future pain point as you're constantly fighting with new tests that default to the ShellImage
A lot of tests use ShellImage, wouldn't it be better to make this work on microshift (somehow)? It's available in the Red Hat registry I think https://catalog.redhat.com/software/containers/openshift4/ose-tools-rhel8/5f748d3399cc5b9e7c1a8747?architecture=amd64&image=654d55b19bad3d62eaba06ce&container-tabs=overview
Maybe it be possible to use an ICSP to route the cli and tools images to a public registry on Microshift?
https://github.com/openshift/origin/blob/acfaf0a446cc3d5dfff2a68adbcde5d5678df31c/test/extended/util/image/image.go#L26-L29
test/extended/util/image/README.mdreccomends this is the default image folks use, so I could see this being a future pain point as you're constantly fighting with new tests that default to the ShellImage
MicroShift does not have the image apigroup, meaning we can not rely on local registries (neither ICSP) unless they are setup for the CI job. This is why we need to resolve to use public available images/registries. The agnhost image has the tools we need in those tests and it will still work in OCP, since there are other tests pulling it.
A lot of tests use ShellImage, wouldn't it be better to make this work on microshift (somehow)? It's available in the Red Hat registry I think https://catalog.redhat.com/software/containers/openshift4/ose-tools-rhel8/5f748d3399cc5b9e7c1a8747?architecture=amd64&image=654d55b19bad3d62eaba06ce&container-tabs=overview
Is it possible to make the test suite use that image directly instead of referring to the image that's in the payload? We would need another test to ensure that payload image still works, but we could skip that test on MicroShift.
I didn't realize how limited Microshift's API's were. If the router folks are OK with using the AgnHost image for their tests that's fine, but I don't want to step on their toes for that. Ask someone here for a review if you want to go through that approach: https://github.com/openshift/origin/blob/1d2b10e90893e0c31528f300467ce3e1c9504d4e/test/extended/router/OWNERS
But in general, if you can make ShellImage work on Microshift you'll be better off in the long run. It looks like the only images we expect to be present in the cluster are cli and tools for openshift-tests. Maybe those could just be added to the payload if they're not too big? Or find a way to get them pointed to a public registry for microshift in https://github.com/openshift/origin/blob/acfaf0a446cc3d5dfff2a68adbcde5d5678df31c/test/extended/util/image/image.go#L27-L28.
@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-single-node | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-csi | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-aws-csi |
| ci/prow/e2e-gcp-csi | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-gcp-csi |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-gcp-ovn-rt-upgrade | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-gcp-ovn-rt-upgrade |
| ci/prow/e2e-openstack-ovn | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | true | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-gcp-ovn | 1d2b10e90893e0c31528f300467ce3e1c9504d4e | link | true | /test e2e-gcp-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
