openshift
[WIP] Refactor `test/extended/util/client.go`
This PR does the following things at a high level:
- cleans up
test/extended/util/client.goto get rid of duplicate code and ensure all creation goes through the exact same path - singleNewCLImethod with a structure that allows you to configure the necessary variant - keep explicit separation between admin and user config files to allow easily switching users, without creating new copies of the same resources, which then leads to resources not being cleaned up
- moves non-CLI helpers to their own files
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: soltysh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [soltysh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Job Failure Risk Analysis for sha: cbcf49da60b8f6a9f8de2c39d92981f5e020d8ac
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-openstack-ovn | IncompleteTests Tests for this run (100) are below the historical average (2080): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 | IncompleteTests Tests for this run (20) are below the historical average (1905): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-metal-ipi-ovn | IncompleteTests Tests for this run (20) are below the historical average (2022): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade | IncompleteTests Tests for this run (103) are below the historical average (812): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade | IncompleteTests Tests for this run (103) are below the historical average (867): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn-builds | IncompleteTests Tests for this run (102) are below the historical average (984): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-ovn | IncompleteTests Tests for this run (102) are below the historical average (1877): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-gcp-csi | IncompleteTests Tests for this run (102) are below the historical average (834): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt | IncompleteTests Tests for this run (22) are below the historical average (580): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade | IncompleteTests Tests for this run (104) are below the historical average (935): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade | IncompleteTests Tests for this run (103) are below the historical average (2748): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial | IncompleteTests Tests for this run (102) are below the historical average (893): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node | IncompleteTests Tests for this run (102) are below the historical average (2047): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-serial | IncompleteTests Tests for this run (102) are below the historical average (952): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial | IncompleteTests Tests for this run (104) are below the historical average (436): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-fips | IncompleteTests Tests for this run (102) are below the historical average (2024): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-edge-zones | IncompleteTests Tests for this run (103) are below the historical average (2190): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2 | IncompleteTests Tests for this run (102) are below the historical average (1993): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-csi | IncompleteTests Tests for this run (102) are below the historical average (856): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd | IncompleteTests Tests for this run (102) are below the historical average (839): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-gcp-ovn-image-ecosystem | e8ded07b9036d82c28588a53e5aceee47d201028 | link | true | /test e2e-gcp-ovn-image-ecosystem |
| ci/prow/e2e-aws-ovn-upgrade | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-upgrade |
| ci/prow/e2e-aws-ovn-ipsec-serial | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-ipsec-serial |
| ci/prow/e2e-gcp-ovn-builds | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-gcp-ovn-builds |
| ci/prow/e2e-aws-ovn-edge-zones | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-aws-ovn-edge-zones |
| ci/prow/e2e-openstack-ovn | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-openstack-ovn |
| ci/prow/e2e-metal-ipi-ovn | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-metal-ipi-ovn |
| ci/prow/e2e-metal-ipi-ovn-ipv6 | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-metal-ipi-ovn-ipv6 |
| ci/prow/e2e-aws-ovn-image-registry | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-aws-ovn-image-registry |
| ci/prow/e2e-aws-ovn-cgroupsv2 | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-cgroupsv2 |
| ci/prow/e2e-gcp-ovn | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-gcp-ovn |
| ci/prow/e2e-aws-ovn-single-node-serial | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-single-node-serial |
| ci/prow/e2e-aws-ovn-single-node | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-gcp-ovn-rt-upgrade | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-gcp-ovn-rt-upgrade |
| ci/prow/e2e-aws-ovn-serial | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-aws-ovn-serial |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-gcp-ovn-upgrade | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-gcp-ovn-upgrade |
| ci/prow/e2e-baremetalds-kubevirt | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-baremetalds-kubevirt |
| ci/prow/e2e-aws-ovn-fips | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | true | /test e2e-aws-ovn-fips |
| ci/prow/e2e-agnostic-ovn-cmd | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-agnostic-ovn-cmd |
| ci/prow/e2e-aws-ovn-kubevirt | 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98 | link | false | /test e2e-aws-ovn-kubevirt |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Job Failure Risk Analysis for sha: 2d3fb70fd12de2afaef75db87c2a79d4bfab9e98
| Job Name | Failure Risk |
|---|---|
| pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade | IncompleteTests Tests for this run (985) are below the historical average (2774): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |
| pull-ci-openshift-origin-master-e2e-aws-ovn-ipsec-serial | IncompleteTests Tests for this run (27) are below the historical average (415): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems) |