origin icon indicating copy to clipboard operation
origin copied to clipboard

NE-1526: Re-introduce the DNS CI coverage for golang and glibc resolver libraries

Open gcs278 opened this issue 2 years ago • 50 comments

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take ownership of the PR.

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1 along with some improvements, notably the ability to test multiple Go versions.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi9/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Story is NE-1526 Epic is NE-626

gcs278 avatar Jan 10 '23 14:01 gcs278

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.

Modifications to the previous closed PR:

  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 18 '23 22:01 openshift-ci-robot

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.

Modifications to the previous closed PR:

  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 18 '23 22:01 openshift-ci-robot

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.

Modifications to the previous closed PR (from when I took over from Suleyman:

  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 18 '23 22:01 openshift-ci-robot

@gcs278: This pull request references [Jira Issue NE-626](https://issues.redhat.com//browse/NE-626), which is a valid jira issue.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Jan 18 '23 22:01 openshift-ci-robot

/assign @rfredette

candita avatar Jan 25 '23 17:01 candita

/retest

gcs278 avatar Jan 30 '23 19:01 gcs278

/retest

jerpeter1 avatar Mar 21 '23 15:03 jerpeter1

@rfredette just a reminder for a review when the dust settles from 4.13 bugs.

gcs278 avatar Mar 22 '23 14:03 gcs278

@rfredette just a reminder for a review when the dust settles from 4.14 bugs.

gcs278 avatar Jun 07 '23 21:06 gcs278

/retest

rfredette avatar Jun 14 '23 15:06 rfredette

/approve

@gcs278 I'm not sure why github isn't calling this out, but based on the retest results, it looks like this needs a rebase. Once it's been rebased, I'll lgtm this as well.

rfredette avatar Jun 14 '23 16:06 rfredette

/hold Thanks for the review @rfredette. Looking back at this PR after a long break, something feels awkward about this test. I'm going to put it on hold for now.

Essentially, we have a floating and always moving target version of GO, that we want to test. The code:

goVersions := []string{"1.16.12", "1.17", "1.18", "latest"}

Feels weird to me, because I know it's going to get outdated. Say in 3 years, we are now running with GO 1.27 because latest=GO 1.27. Well, the test is now skipping 1.19 - 1.26, but still testing 1.16 - 1.18. That feels awkward to me. I know no one is going to come back and update this code (that's how things go in software right?).

I wonder if it makes sense to test with just latest. The idea is that latest will allow us to gradually be fed the new versions of GO, but the assumption is that we don't need to continually test the previous versions. Still, it feels weird to me that we have an externally moving target (GO Version) that this test is at the mercy of.

gcs278 avatar Jun 28 '23 16:06 gcs278

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Sep 27 '23 01:09 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Oct 27 '23 08:10 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Nov 27 '23 00:11 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 27 '23 00:11 openshift-ci[bot]

We still want this test coverage.
/reopen /remove-lifecycle rotten

Miciah avatar Feb 28 '24 15:02 Miciah

@gcs278: This pull request references NE-626 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.16.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 28 '24 15:02 openshift-ci-robot

@Miciah: Reopened this PR.

In response to this:

We still want this test coverage.
/reopen /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 28 '24 15:02 openshift-ci[bot]

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-626

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 19:02 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-1526

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 19:02 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-1526

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Feb 29 '24 19:02 openshift-ci-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar May 30 '24 01:05 openshift-bot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR

Story is NE-1526

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb.

Modifications to the previous reverted PR:

  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • A test for Go 1.16, 1.17, 1.18, and the latest GO version were added.
  • A check for baremetal environment was added to skip the test, as this environment is disconnected and does not have any suitable images on the local registry to use for different Go versions.
  • Converted dns_library_go.yaml to be a dynamic part of code
  • Added a build arg for the Dockerfile FROM base image, so that it could be dynamically populated
  • Reduced testdata directories go-v1-16 and go-v1-17 to be a single go-library-test directory. Now you can add a new GO version test just by adding to the GO Version Slice
  • Added latest as a test for the latest GO version so the test won't go stale.
  • Used e2e.RunHostCmd for simplifying some logic

WIP: Reviewing the PR, making some improvements, and need to update descriptions/commit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 25 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR.

Story is NE-1526

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR.

Story is NE-1526 Epic is NE-1075

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take over the PR.

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Story is NE-1526 Epic is NE-1075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take ownership of the PR.

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Story is NE-1526 Epic is NE-1075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take ownership of the PR.

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1 along with some improvements, notably the ability to test multiple Go versions.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Story is NE-1526 Epic is NE-1075

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot

@gcs278: This pull request references NE-1526 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Cloned from https://github.com/openshift/origin/pull/27135 so that I can take ownership of the PR.

This PR re-introduces the DNS CI coverage for golang and glibc resolver libraries by reverting https://github.com/openshift/origin/commit/4a1e80297759a22a4cae03c3deb6171c0fd382eb which reverted https://github.com/openshift/origin/commit/768de2f6fe0b17c134f070550baed5503ab8a4f1 along with some improvements, notably the ability to test multiple Go versions.

Modifications to the previous reverted https://github.com/openshift/origin/pull/26957 include:

  • Skip baremetal environments because they are disconnected and lack suitable images on the local registry to use for testing different Go versions. This addresses the reason for the revert.
  • Add subdirectory go-dns-resolver in test/extended/testdata/dns/ to be more organized for future DNS tests.
  • Add testing for each Go version starting from 1.17 to the latest Go version.
  • Base image for Go test was changed from golang in Docker Hub to registry.redhat.io/ubi8/go-toolset.
  • Convert dns_library_go.yaml to be created in code and use a Pod instead of deprecated DeploymentConfig.
  • Added a build arg for the Dockerfile FROM base image, so one Dockerfile can be used for multiple tests.
  • General comment, logging, and error handling clean up.

Story is NE-1526 Epic is NE-626

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 26 '24 00:06 openshift-ci-robot