origin icon indicating copy to clipboard operation
origin copied to clipboard

Ensures CCCMO and KCMO use external cloud provider

Open MaysaMacedo opened this issue 2 years ago • 2 comments

OpenStack platform is moving from in-tree cloud provider to external one. The switch to external cloud provider has to be done at the same time for the cluster cloud controller manager operator and kube controller manager operator to avoid the two providers being used in the cluster. This commit includes a new test scenario to check that external provider is properly configured in both operators.

MaysaMacedo avatar Aug 09 '22 15:08 MaysaMacedo

Changes look good, do we have any optional openstack jobs that we can run to test this?

JoelSpeed avatar Aug 15 '22 09:08 JoelSpeed

/test e2e-openstack

MaysaMacedo avatar Aug 15 '22 09:08 MaysaMacedo

Changes look good, do we have any optional openstack jobs that we can run to test this?

@JoelSpeed yes, I just triggered it

MaysaMacedo avatar Aug 15 '22 09:08 MaysaMacedo

/test e2e-openstack

MaysaMacedo avatar Aug 15 '22 09:08 MaysaMacedo

/test e2e-openstack

MaysaMacedo avatar Aug 15 '22 10:08 MaysaMacedo

/test e2e-openstack /test e2e-gcp-upgrade

MaysaMacedo avatar Aug 15 '22 13:08 MaysaMacedo

/test e2e-openstack retrying, infra issues

MaysaMacedo avatar Aug 15 '22 15:08 MaysaMacedo

/test e2e-openstack

MaysaMacedo avatar Aug 16 '22 08:08 MaysaMacedo

@JoelSpeed The test just passed: passed: (3.9s) 2022-08-16T11:04:48 "[sig-cloud-provider][Feature:OpenShiftCloudControllerManager][Late] Deploy an external cloud provider [Suite:openshift/conformance/parallel]"

MaysaMacedo avatar Aug 16 '22 12:08 MaysaMacedo

/retest-required

MaysaMacedo avatar Aug 16 '22 12:08 MaysaMacedo

Cool, thanks for checking in on the results

/lgtm

JoelSpeed avatar Aug 16 '22 12:08 JoelSpeed

/assign @deads2k

MaysaMacedo avatar Aug 16 '22 13:08 MaysaMacedo

/assign @danwinship

MaysaMacedo avatar Aug 23 '22 11:08 MaysaMacedo

/test verify-deps

MaysaMacedo avatar Aug 24 '22 10:08 MaysaMacedo

/lgtm

JoelSpeed avatar Aug 24 '22 11:08 JoelSpeed

/test e2e-aws-serial

MaysaMacedo avatar Aug 24 '22 14:08 MaysaMacedo

/approve /hold

please add a test/extended/cloud_controller_manager OWNERS file so that you can maintain/merge changes to this test on your own going forward

bparees avatar Aug 24 '22 14:08 bparees

/lgtm

Owners file added

/hold cancel

JoelSpeed avatar Aug 24 '22 15:08 JoelSpeed

/retest-required

Remaining retests: 2 against base HEAD 4eea7e4977154defcb30b462ec9f030acbd225bf and 8 for PR HEAD d07ad3d2a9403803081e781164d277ec2b81eee8 in total

openshift-ci-robot avatar Aug 25 '22 06:08 openshift-ci-robot

/retest-required

Remaining retests: 1 against base HEAD 4eea7e4977154defcb30b462ec9f030acbd225bf and 7 for PR HEAD d07ad3d2a9403803081e781164d277ec2b81eee8 in total

openshift-ci-robot avatar Aug 25 '22 09:08 openshift-ci-robot

/lgtm

JoelSpeed avatar Aug 26 '22 10:08 JoelSpeed

/test e2e-aws-serial

JoelSpeed avatar Aug 26 '22 13:08 JoelSpeed

/approve

danwinship avatar Aug 26 '22 13:08 danwinship

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, danwinship, JoelSpeed, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 26 '22 13:08 openshift-ci[bot]

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack dee06200b9ca8d259d1cda5cbd4d6e2a9ea43614 link false /test e2e-openstack
ci/prow/e2e-aws-single-node 5487414d8f5652c301a00617ee18e5ca8f339cb4 link false /test e2e-aws-single-node
ci/prow/e2e-aws-single-node-upgrade 5487414d8f5652c301a00617ee18e5ca8f339cb4 link false /test e2e-aws-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 26 '22 16:08 openshift-ci[bot]