origin
origin copied to clipboard
openshift
USHIFT-285: Add MicroShift version getter to framework
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
The implementation looks good. Are those CI job failures related?
Not really, this function is not used yet. Anyway I tmeporarily removed the call from GetControlPlaneTopology to inspect if we might enable bad code paths in other tests.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dhellmann, pacevedom
Once this PR has been reviewed and has the lgtm label, please ask for approval from knobunc by writing /assign @knobunc in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
let's see where this is needed instead of using existing external signals before merging.
@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-single-node-upgrade | 0225280079a2ac3c6f91c4f34b57eea9837d10ec | link | false | /test e2e-aws-single-node-upgrade |
| ci/prow/e2e-aws-single-node | 0225280079a2ac3c6f91c4f34b57eea9837d10ec | link | false | /test e2e-aws-single-node |
| ci/prow/e2e-agnostic-cmd | 0225280079a2ac3c6f91c4f34b57eea9837d10ec | link | false | /test e2e-agnostic-cmd |
| ci/prow/e2e-aws-ovn-single-node-upgrade | 648b23844f520086bab0eb011e078ad9548bae26 | link | false | /test e2e-aws-ovn-single-node-upgrade |
| ci/prow/e2e-aws-ovn-serial | 648b23844f520086bab0eb011e078ad9548bae26 | link | true | /test e2e-aws-ovn-serial |
| ci/prow/e2e-gcp-ovn-upgrade | 648b23844f520086bab0eb011e078ad9548bae26 | link | true | /test e2e-gcp-ovn-upgrade |
| ci/prow/e2e-aws-ovn-single-node | 648b23844f520086bab0eb011e078ad9548bae26 | link | false | /test e2e-aws-ovn-single-node |
| ci/prow/e2e-aws-ovn-single-node-serial | 648b23844f520086bab0eb011e078ad9548bae26 | link | false | /test e2e-aws-ovn-single-node-serial |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/hold
let's see where this is needed instead of using existing external signals before merging.
So it's these tests now:
"[sig-auth][Feature:PodSecurity] restricted-v2 SCC should mutate empty securityContext to match restricted PSa profile [Suite:openshift/conformance/parallel]"
"[sig-auth][Feature:OpenShiftAuthorization] The default cluster RBAC policy should have correct RBAC rules [Suite:openshift/conformance/parallel]"
"[sig-coreos] [Conformance] CoreOS bootimages TestBootimagesPresent [Suite:openshift/conformance/parallel/minimal]"
"[sig-devex][Feature:OpenShiftControllerManager] TestAutomaticCreationOfPullSecrets [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]"
"[sig-devex][Feature:OpenShiftControllerManager] TestDockercfgTokenDeletedController [Suite:openshift/conformance/parallel]"
"[sig-imageregistry][Feature:ImageInfo] Image info should display information about images [Skipped:Disconnected] [Suite:openshift/conformance/parallel]"
"[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router converges when multiple routers are writing conflicting status [Suite:openshift/conformance/parallel]"
"[sig-network][Feature:Router][apigroup:route.openshift.io] The HAProxy router converges when multiple routers are writing status [Suite:openshift/conformance/parallel]"
More to come as we create/modify specific tests for microshift, I would say.