origin icon indicating copy to clipboard operation
origin copied to clipboard

Bug 2100091: Ignore FailedCreatePodSandBox events for garbage collector tests

Open pacevedom opened this issue 3 years ago • 6 comments
trafficstars

Garbage collector tests dont care about pod being available/running, they are only testing owner references. If CNI is slow to respond the pod is deleted by the time it needs it, rendering warning events for a failure to create pod sandbox. This PR removes checks for such events, as they might happen even when the test succeeds.

pacevedom avatar Jun 22 '22 07:06 pacevedom

@pacevedom: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade 477db2a80d60d4c1a894c3e01886f784169b0d20 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 477db2a80d60d4c1a894c3e01886f784169b0d20 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-agnostic-cmd 477db2a80d60d4c1a894c3e01886f784169b0d20 link false /test e2e-agnostic-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 22 '22 10:06 openshift-ci[bot]

@pacevedom: This pull request references Bugzilla bug 2100091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2100091: Ignore FailedCreatePodSandBox events for garbage collector tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 22 '22 12:06 openshift-ci[bot]

/lgtm /assign @stbenjam

This looks good, hopefully it will help cleanup the signal coming out of this historically problematic test. Thanks!

dgoodwin avatar Jun 22 '22 12:06 dgoodwin

/bugzilla refresh

eggfoobar avatar Jun 24 '22 14:06 eggfoobar

@eggfoobar: This pull request references Bugzilla bug 2100091, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Jun 24 '22 14:06 openshift-ci[bot]

/retest-required

eggfoobar avatar Sep 06 '22 15:09 eggfoobar

/approve

stbenjam avatar Sep 06 '22 16:09 stbenjam

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, pacevedom, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 06 '22 16:09 openshift-ci[bot]

@pacevedom: All pull requests linked via external trackers have merged:

Bugzilla bug 2100091 has been moved to the MODIFIED state.

In response to this:

Bug 2100091: Ignore FailedCreatePodSandBox events for garbage collector tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 07 '22 00:09 openshift-ci[bot]