origin icon indicating copy to clipboard operation
origin copied to clipboard

Bug 1992596: e2e/cli: Migrate set-image.sh to Go test

Open rosspeoples opened this issue 3 years ago • 7 comments

Migrate test from bash and fix flaky test

/assign @soltysh /cc @ardaguclu

rosspeoples avatar Apr 22 '22 17:04 rosspeoples

@deejross: This pull request references Bugzilla bug 1992596, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @zhouying7780

In response to this:

Bug 1992596: e2e/cli: Migrate set-image.sh to Go test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 22 '22 17:04 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deejross To complete the pull request process, please ask for approval from soltysh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Apr 22 '22 19:04 openshift-ci[bot]

/retest

rosspeoples avatar Apr 24 '22 18:04 rosspeoples

To ensure this PR does not break IPv6; /test e2e-metal-ipi-ovn-ipv6

ardaguclu avatar Apr 25 '22 09:04 ardaguclu

The failure from https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/27046/pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6/1518519556195225600 looks related to this PR, probably worth picking a different image, one of the mirrorred ones, see k8s.io/kubernetes/test/utils/image for those

soltysh avatar Apr 26 '22 18:04 soltysh

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 09 '22 01:08 openshift-bot

@deejross: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade aacfee70d2d0fb3dd8239c2956980fb137328200 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-serial aacfee70d2d0fb3dd8239c2956980fb137328200 link true /test e2e-aws-serial
ci/prow/e2e-aws-single-node aacfee70d2d0fb3dd8239c2956980fb137328200 link false /test e2e-aws-single-node
ci/prow/e2e-aws-single-node-upgrade aacfee70d2d0fb3dd8239c2956980fb137328200 link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 aacfee70d2d0fb3dd8239c2956980fb137328200 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-serial aacfee70d2d0fb3dd8239c2956980fb137328200 link true /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 31 '22 21:08 openshift-ci[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Oct 01 '22 08:10 openshift-bot

@deejross: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Oct 01 '22 08:10 openshift-merge-robot

This needs to be redone, so closing for now

rosspeoples avatar Oct 05 '22 13:10 rosspeoples

@deejross: This pull request references Bugzilla bug 1992596. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1992596: e2e/cli: Migrate set-image.sh to Go test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 05 '22 14:10 openshift-ci[bot]