origin icon indicating copy to clipboard operation
origin copied to clipboard

Enable ServiceInternalTrafficPolicy tests in OVNK

Open tssurya opened this issue 2 years ago • 15 comments

We support ITP=local from 4.11 so let's enable the tests for this feature which were disabled.

Signed-off-by: Surya Seetharaman [email protected]

tssurya avatar Apr 22 '22 12:04 tssurya

/hold till https://github.com/openshift/ovn-kubernetes/pull/1049/commits/87ce7b6715fb4ad20933ec11b6547a4e1742caaa merges

tssurya avatar Apr 22 '22 12:04 tssurya

/assign @trozet

tssurya avatar Apr 22 '22 12:04 tssurya

/retest

tssurya avatar Apr 23 '22 19:04 tssurya

/retest

tssurya avatar Apr 24 '22 10:04 tssurya

/hold cancel downstream PR for the feature has merged.

tssurya avatar Apr 25 '22 10:04 tssurya

/lgtm

martinkennelly avatar Apr 25 '22 10:04 martinkennelly

/test ci/prow/e2e-gcp-ovn

martinkennelly avatar Apr 25 '22 10:04 martinkennelly

@martinkennelly: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-cgroupsv2
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-single-node
  • /test e2e-aws-single-node-serial
  • /test e2e-aws-single-node-upgrade
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-aws-single-node
  • pull-ci-openshift-origin-master-e2e-aws-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-builds
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps

In response to this:

/test ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 25 '22 10:04 openshift-ci[bot]

/test e2e-aws-ovn

martinkennelly avatar Apr 25 '22 10:04 martinkennelly

/hold, good call on running the e2e-aws-ovn job, seems like one ITP test is failing which I don't know why...because it passed in upstream OVN-K...

tssurya avatar Apr 25 '22 16:04 tssurya

/hold

tssurya avatar Apr 25 '22 16:04 tssurya

passing: : [sig-network] Services should respect internalTrafficPolicy=Local Pod and Node, to Pod (hostNetwork: true) [Feature:ServiceInternalTrafficPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s] : [sig-network] Services should respect internalTrafficPolicy=Local Pod to Pod [Feature:ServiceInternalTrafficPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]

failing: [sig-network] Services should respect internalTrafficPolicy=Local Pod (hostNetwork: true) to Pod [Feature:ServiceInternalTrafficPolicy] [Suite:openshift/conformance/parallel] [Suite:k8s]

tssurya avatar Apr 25 '22 16:04 tssurya

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 09 '22 01:08 openshift-bot

/remove-lifecycle stale

tssurya avatar Sep 01 '22 13:09 tssurya

/retest

tssurya avatar Sep 01 '22 13:09 tssurya

/lgtm

trozet avatar Sep 01 '22 15:09 trozet

/hold cancel

tssurya avatar Sep 02 '22 17:09 tssurya

/retest

tssurya avatar Sep 02 '22 17:09 tssurya

/approve

trozet avatar Sep 02 '22 17:09 trozet

/assign @derekwaynecarr

trozet avatar Sep 02 '22 18:09 trozet

/retest

tssurya avatar Sep 03 '22 08:09 tssurya

/retest

tssurya avatar Sep 05 '22 10:09 tssurya

/retest

tssurya avatar Sep 06 '22 10:09 tssurya

/approve

Very excited to see this change!

knobunc avatar Sep 08 '22 13:09 knobunc

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, martinkennelly, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 08 '22 13:09 openshift-ci[bot]

/retest

tssurya avatar Sep 08 '22 16:09 tssurya

/retest-required

Remaining retests: 0 against base HEAD 7d1315ece0e4e0efb5196821af0736914bab69d4 and 2 for PR HEAD b8833eeb089b8b3b9cb2242265c94ea0461a8e7f in total

openshift-ci-robot avatar Sep 08 '22 19:09 openshift-ci-robot

/retest-required

tssurya avatar Sep 09 '22 09:09 tssurya

@knobunc : could we override the e2e-gcp-builds job on this one? e2e-gcp-builds is Perma Failing: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-master-e2e-gcp-builds

tssurya avatar Sep 09 '22 10:09 tssurya

serial job also needs a skip due to https://issues.redhat.com/browse/OCPBUGS-1083 has nothing to do with this PR

tssurya avatar Sep 09 '22 13:09 tssurya