origin icon indicating copy to clipboard operation
origin copied to clipboard

CLI buildconfig: Don't expect apiserver port to end with 443

Open alvaroaleman opened this issue 2 years ago • 6 comments

The tests currently get the apiserver address by calling oc --namespace=default status and then extracting the apiserver with a regex that expects its port to end with 443. This breaks when the apiserver doesn't have such a port.

Just use the host from the kubeconfig instead.

alvaroaleman avatar Mar 10 '22 18:03 alvaroaleman

/assign soltysh

alvaroaleman avatar Mar 10 '22 18:03 alvaroaleman

/retest-required

alvaroaleman avatar Mar 29 '22 18:03 alvaroaleman

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alvaroaleman To complete the pull request process, please ask for approval from soltysh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 30 '22 13:03 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 09 '22 01:08 openshift-bot

@alvaroaleman: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Aug 31 '22 17:08 openshift-merge-robot

@alvaroaleman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-gcp
ci/prow/e2e-gcp-csi 43147b4a15f059b1c78be81de0d06eec7c756476 link false /test e2e-gcp-csi
ci/prow/e2e-gcp-builds 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-gcp-builds
ci/prow/e2e-aws-fips 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-aws-fips
ci/prow/e2e-aws-serial 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-aws-serial
ci/prow/e2e-aws-single-node 43147b4a15f059b1c78be81de0d06eec7c756476 link false /test e2e-aws-single-node
ci/prow/verify 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test verify
ci/prow/e2e-aws-csi 43147b4a15f059b1c78be81de0d06eec7c756476 link false /test e2e-aws-csi
ci/prow/e2e-gcp-upgrade 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-gcp-upgrade
ci/prow/e2e-aws-cgroupsv2 43147b4a15f059b1c78be81de0d06eec7c756476 link false /test e2e-aws-cgroupsv2
ci/prow/e2e-agnostic-cmd 43147b4a15f059b1c78be81de0d06eec7c756476 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-ovn-fips 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn-upgrade 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn 43147b4a15f059b1c78be81de0d06eec7c756476 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 31 '22 17:08 openshift-ci[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Oct 01 '22 00:10 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Oct 31 '22 08:10 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 31 '22 08:10 openshift-ci[bot]