origin icon indicating copy to clipboard operation
origin copied to clipboard

add some QE approvers/reviewers

Open jianzhangbjz opened this issue 2 years ago • 5 comments

Openshift QEs are encouraged to contribute test cases to the origin repo. To balance the PR review workloads, I add some reviewers and approvers who have rich experience with Golang.

As the distribution of the PRs based on the component, the PR review process for QE:

  1. The PR owner, teams, groups to review the PR and add /lgtm label if the PR looks good. The reviewer should guarantee the case's quality.
  2. The approvers add the /approve label if it looks good. The approver should guarantee the case quality at a high level, such as, if it will break other cases.

cc: @xltian @chengzhang1016

jianzhangbjz avatar Mar 09 '22 04:03 jianzhangbjz

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jianzhangbjz To complete the pull request process, please assign bparees after the PR has been reviewed. You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 09 '22 04:03 openshift-ci[bot]

/uncc I don't feel like I have enough approval power here that I should be approving new approvers...

danwinship avatar Mar 21 '22 12:03 danwinship

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 09 '22 01:08 openshift-bot

/remove-lifecycle stale

jianzhangbjz avatar Aug 09 '22 02:08 jianzhangbjz

@jianzhangbjz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-aws-single-node
ci/prow/e2e-gcp-csi 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-gcp-csi
ci/prow/e2e-agnostic-cmd 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-ovn-serial 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 31 '22 21:08 openshift-ci[bot]

@jianzhangbjz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Oct 12 '22 13:10 openshift-merge-robot

@jianzhangbjz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-aws-single-node
ci/prow/e2e-gcp-csi 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-gcp-csi
ci/prow/e2e-agnostic-cmd 40a103b5ad9649c158b79780b1cb179c3668f4f8 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-ovn-serial 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-fips 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-aws-ovn-fips
ci/prow/e2e-gcp-ovn 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-gcp-ovn
ci/prow/unit 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test unit
ci/prow/e2e-aws-ovn-image-registry 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-aws-ovn-image-registry
ci/prow/e2e-gcp-ovn-builds 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-gcp-ovn-image-ecosystem 40a103b5ad9649c158b79780b1cb179c3668f4f8 link true /test e2e-gcp-ovn-image-ecosystem

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 04 '22 22:11 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Feb 03 '23 09:02 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Mar 06 '23 00:03 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Apr 05 '23 08:04 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Apr 05 '23 08:04 openshift-ci[bot]