origin icon indicating copy to clipboard operation
origin copied to clipboard

Github ping event causes a re-build

Open dpkshetty opened this issue 3 years ago • 4 comments

When I setup a github webhook using the "generic webhook" URL from my openshift deployment's build config page... github as part of new webhook setup, sends a ping event, and openshift is re-building and re-deploying my pod which is not expected as openshift should only re-build for a push event only!

Version

[provide output of the openshift version or oc version command]

Steps To Reproduce

I lost the setup I had.. but here are the high level steps...

  1. Deploy some application using Github as the source
  2. Setup new github webhook using the "generic webhook" URL option from the deployment's build config
  3. github sends a ping event to openshift
  4. openshift re-builds - which is incorrect
Current Result

Openshift re-builds the appln/pod when github sends a ping event

Expected Result

Openshift should ignore when github sends a ping event It should re-build only for a push event

Additional Information

Not sure if this helps, but when I use "github webhook" URL from the build config, openshift does not re-build on a ping event

dpkshetty avatar Feb 09 '22 09:02 dpkshetty

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar May 10 '22 12:05 openshift-bot

/remove-lifecycle stale

dpkshetty avatar May 10 '22 13:05 dpkshetty

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Aug 08 '22 19:08 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Sep 08 '22 00:09 openshift-bot

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Oct 08 '22 08:10 openshift-bot

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Oct 08 '22 08:10 openshift-ci[bot]