origin icon indicating copy to clipboard operation
origin copied to clipboard

Bug 1989169: Enable "Unidling should work with TCP" tests

Open jluhrsen opened this issue 3 years ago • 46 comments

Signed-off-by: Jamo Luhrsen [email protected]

jluhrsen avatar Sep 10 '21 17:09 jluhrsen

@jluhrsen: This pull request references Bugzilla bug 1989169, which is invalid:

  • expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1989169: Enable "Unidling should work with TCP" tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 10 '21 17:09 openshift-ci[bot]

/bugzilla refresh

jluhrsen avatar Sep 10 '21 17:09 jluhrsen

@jluhrsen: This pull request references Bugzilla bug 1989169, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Sep 10 '21 17:09 openshift-ci[bot]

/retest

jcaamano avatar Sep 14 '21 13:09 jcaamano

/retest

jluhrsen avatar Sep 14 '21 17:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 14 '21 17:09 jluhrsen

the two "Unidling should work with TCP" tests did pass in this recent job: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26460/pull-ci-openshift-origin-master-e2e-gcp/1437774641639723008

I will continue to /test e2e-gcp on this PR so we can get a sense of how flaky the tests really are. There is a new bug filed to track any dev work that will be required to un-flake these tests (assuming they are flaky): https://bugzilla.redhat.com/show_bug.cgi?id=2003228

jluhrsen avatar Sep 14 '21 17:09 jluhrsen

/retest

jluhrsen avatar Sep 15 '21 21:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 15 '21 21:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 16 '21 17:09 jluhrsen

for reference, the PR test dashboard: https://prow.ci.openshift.org/pr-history/?org=openshift&repo=origin&pr=26460

jluhrsen avatar Sep 16 '21 17:09 jluhrsen

/lgtm ☺️

flavio-fernandes avatar Sep 17 '21 01:09 flavio-fernandes

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flavio-fernandes, jluhrsen To complete the pull request process, please assign derekwaynecarr after the PR has been reviewed. You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 17 '21 02:09 openshift-ci[bot]

/test e2e-gcp

jluhrsen avatar Sep 17 '21 15:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 17 '21 16:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 17 '21 19:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 17 '21 21:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 19 '21 16:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 21 '21 04:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 21 '21 16:09 jluhrsen

@danwinship , I think these tests are no longer flaking. I ran the job 10 times in a row without a failure. you can see it here: https://prow.ci.openshift.org/pr-history/?org=openshift&repo=origin&pr=26460

I think it's safe to merge this.

jluhrsen avatar Sep 22 '21 02:09 jluhrsen

The bug is about them flaking under ovn-kubernetes. It appears that no ovn tests are being run by default in origin master right now? So you'd have to manually /test e2e-aws-ovn /test e2e-gcp-ovn

danwinship avatar Sep 22 '21 15:09 danwinship

hm, no gcp ovn job here /test e2e-metal-ipi-ovn-dualstack

danwinship avatar Sep 22 '21 15:09 danwinship

The bug is about them flaking under ovn-kubernetes. It appears that no ovn tests are being run by default in origin master right now? So you'd have to manually /test e2e-aws-ovn /test e2e-gcp-ovn

doh! I knew that. my bad. I saw the e2e-aws-ovn came back now and it did have one failure: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/26460/pull-ci-openshift-origin-master-e2e-aws-ovn/1440695779755823104

This is the bz I filed to get these tests un-flakey: https://bugzilla.redhat.com/show_bug.cgi?id=2003228

jluhrsen avatar Sep 22 '21 16:09 jluhrsen

/test e2e-aws-ovn

jluhrsen avatar Sep 22 '21 16:09 jluhrsen

/test e2e-aws-ovn

jluhrsen avatar Sep 22 '21 19:09 jluhrsen

/test e2e-aws-ovn

jluhrsen avatar Sep 22 '21 20:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 23 '21 02:09 jluhrsen

/test e2e-gcp

jluhrsen avatar Sep 23 '21 17:09 jluhrsen

/test e2e-aws-ovn

jluhrsen avatar Sep 23 '21 17:09 jluhrsen