origin icon indicating copy to clipboard operation
origin copied to clipboard

Make registry tests using docker.socket dockerless

Open miminar opened this issue 7 years ago • 5 comments

The tests using the docker socket fail because the access is not granted anymore in pods. Therefore they are now being marked with [local].

This issue is a reminder to rewrite the tests in a dockerless way.

See the related discussion:

  • https://github.com/openshift/image-registry/pull/87#issuecomment-399261119

And related [local] PRs:

  • https://github.com/openshift/origin/pull/20077
  • https://github.com/openshift/origin/pull/20061

miminar avatar Jun 22 '18 15:06 miminar

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Oct 01 '18 21:10 openshift-bot

/lifecycle frozen /remove-lifecycle stale

/assign @dmage

This is more urgent than before as these tests are not being run anywhere anymore i do not believe, until we remove the local tag.

bparees avatar Oct 30 '18 13:10 bparees

might be possible to use oc image mirror to push an image from docker hub into the registry for these tests, too.

bparees avatar Oct 31 '18 12:10 bparees

I would like to contribute to this issue. Kindly guide me through the steps as I am a newbie in this field.

gitsan13 avatar Sep 07 '22 12:09 gitsan13

@gitsan13 one set of tests that are marked as [Local] is here:

https://github.com/openshift/origin/blob/e8d48e35ca02ecd5463db2684c8c99a272d27319/test/extended/images/prune.go#L34

But it's a pretty tricky issue. Why did you choose it? Before you start working on any test, you need to get a working OpenShift or OKD cluster and learn how to run tests. This alone can be overwhelming.

dmage avatar Sep 07 '22 13:09 dmage