OSDOCS-11720#updating commands
Versions: 4.17+
Issue: https://issues.redhat.com/browse/OSDOCS-11720
Link to docs preview: This module update is reflected in these three assemblies:
- Wait for bootstrap completion and remove bootstrap resources in GCP (Installing a cluster on user-provisioned infrastructure in GCP by using Deployment Manager templates)
- Wait for bootstrap completion and remove bootstrap resources in GCP (Installing a cluster into a shared VPC on GCP using Deployment Manager templates)
- Wait for bootstrap completion and remove bootstrap resources in GCP (Installing a cluster on GCP in a disconnected environment with user-provisioned infrastructure
QE review:
- [ ] QE has approved this change.
Additional information:
🤖 Mon Jul 14 12:53:16 - Prow CI generated the docs preview:
https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra.html https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra-vpc.html https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp.html
@jianli-wei, PTAL
@jianli-wei, Thanks for your review comments. Can you take another look?
@brendan-daly-red-hat Just a minor suggestion, how about let the last two delete commands, i.e. "gsutil rb..." and "gcloud deployment-manager deployments delete...", being aligned with the first two commands, i.e. "gcloud compute backend-services remove-backend ${INFRA_ID}-api-internal..." and "ingress_backendservice=...", rather than indented? Thanks!
@jianli-wei Thanks for the suggestion. AFAIK, to align the last two commands with the first two, we need to place the last commands in a new step. Can you suggest text to break the existing text into two rather than one step? I've added sample text in the preview link to give an example.
/label peer-review-needed
@brendan-daly-red-hat A couple of minor suggestions. Otherwise LGTM.
@brendan-daly-red-hat: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
As this bug will be addressed by https://issues.redhat.com/browse/OCPBUGS-60164, I'm closing this PR.