openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-11720#updating commands

Open brendan-daly-red-hat opened this issue 6 months ago • 3 comments

Versions: 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-11720

Link to docs preview: This module update is reflected in these three assemblies:

QE review:

  • [ ] QE has approved this change.

Additional information:

brendan-daly-red-hat avatar Jun 30 '25 14:06 brendan-daly-red-hat

🤖 Mon Jul 14 12:53:16 - Prow CI generated the docs preview:

https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra.html https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-gcp-user-infra-vpc.html https://95450--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_gcp/installing-restricted-networks-gcp.html

ocpdocs-previewbot avatar Jun 30 '25 14:06 ocpdocs-previewbot

@jianli-wei, PTAL

brendan-daly-red-hat avatar Jun 30 '25 15:06 brendan-daly-red-hat

@jianli-wei, Thanks for your review comments. Can you take another look?

brendan-daly-red-hat avatar Jul 03 '25 14:07 brendan-daly-red-hat

@brendan-daly-red-hat Just a minor suggestion, how about let the last two delete commands, i.e. "gsutil rb..." and "gcloud deployment-manager deployments delete...", being aligned with the first two commands, i.e. "gcloud compute backend-services remove-backend ${INFRA_ID}-api-internal..." and "ingress_backendservice=...", rather than indented? Thanks!

jianli-wei avatar Jul 04 '25 01:07 jianli-wei

@jianli-wei Thanks for the suggestion. AFAIK, to align the last two commands with the first two, we need to place the last commands in a new step. Can you suggest text to break the existing text into two rather than one step? I've added sample text in the preview link to give an example.

brendan-daly-red-hat avatar Jul 04 '25 12:07 brendan-daly-red-hat

/label peer-review-needed

brendan-daly-red-hat avatar Jul 08 '25 12:07 brendan-daly-red-hat

@brendan-daly-red-hat A couple of minor suggestions. Otherwise LGTM.

mburke5678 avatar Jul 08 '25 13:07 mburke5678

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 14 '25 12:07 openshift-ci[bot]

As this bug will be addressed by https://issues.redhat.com/browse/OCPBUGS-60164, I'm closing this PR.

brendan-daly-red-hat avatar Aug 26 '25 14:08 brendan-daly-red-hat