openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-56801#Add ztp_07-sriov-related-kernel-args-worker.yaml to RDS

Open amolnar-gh opened this issue 6 months ago • 4 comments

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OCPBUGS-56801

Link to docs preview: https://95267--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco_ref_design_specs/ran/telco-ran-ref-du-crs.html#machine-configuration-crs_ran-ref-design-crs

QE review:

  • [x] QE has approved this change.

Additional information:

amolnar-gh avatar Jun 26 '25 12:06 amolnar-gh

🤖 Mon Jun 30 13:39:03 - Prow CI generated the docs preview:

https://95267--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/telco_ref_design_specs/ran/telco-ran-ref-du-crs.html

ocpdocs-previewbot avatar Jun 26 '25 12:06 ocpdocs-previewbot

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 30 '25 13:06 openshift-ci[bot]

/lgtm

mcornea avatar Jun 30 '25 13:06 mcornea

/label peer-review-needed

amolnar-gh avatar Jun 30 '25 15:06 amolnar-gh

/label merge-review-needed

amolnar-gh avatar Jul 01 '25 14:07 amolnar-gh

/label merge-review-in-progress

michaelryanpeter avatar Jul 01 '25 17:07 michaelryanpeter

LGTM. As a follow up, this section of the docs should be fixed to conform with the conscious language guidelines that have been in place since OCP 4.9. The content should be updated to use the terms control plane and compute machine. There are a lot of different Operators using the same out-of-date terminology, so it might be worth talking to your content strategist about this issue to assess the priority.

michaelryanpeter avatar Jul 01 '25 17:07 michaelryanpeter

Also, there should not be xrefs in this module.

michaelryanpeter avatar Jul 01 '25 17:07 michaelryanpeter

@amolnar-rh When you get the chance, please open a follow up PR to remove the xrefs from the module. Thank you!

michaelryanpeter avatar Jul 01 '25 17:07 michaelryanpeter

@michaelryanpeter I will check with the original writer why they did it this way

amolnar-gh avatar Jul 02 '25 09:07 amolnar-gh