openshift-docs
openshift-docs copied to clipboard
openshift
#CNV-60399 - Clarify the supported Guest
Version(s): 4.16+
Issue: https://issues.redhat.com/browse/CNV-60399
Link to docs preview: https://95208--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html
QE review:
- [ ] QE has approved this change.
Additional information:
🤖 Wed Jul 16 10:37:03 - Prow CI generated the docs preview:
https://95208--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html https://95208--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/virt/managing_vms/virt-edit-vms.html https://95208--ocpdocs-pr.netlify.app/openshift-rosa/latest/virt/managing_vms/virt-edit-vms.html
Hi Vaishali, just a few comments and a request that you provide a preview link to the procedure you've updated (in this case, the preview link would be https://95208--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-edit-vms.html#virt-hot-plugging-memory_virt-edit-vms). Thanks!
/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done
@vsibirsk, Perhaps this link is more appropriate?
cc: @Vaishali-gif-rh, @ctomasko
unfortunately no.
this one is best i could find: https://access.redhat.com/articles/7090862 the requirements section there is what we need here
Hi @vsibirsk, thanks for sharing the link. It looks like it’s for internal use and not accessible to customers. Just checking --do we need to include a link here? If yes, could you please point me to one that’s customer-accessible?
@Vaishali-gif-rh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@vsibirsk - Thank you for your suggestion. I've incorporated the matrix from internal doc, let me know if that looks good.
@ShaunaDiaz: once the present PR merges, I will cherry-pick it on top of enterprise-4.16 in a new PR and assign it to you.
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: once the present PR merges, I will cherry-pick it on top of enterprise-4.17 in a new PR and assign it to you.
In response to this:
/cherrypick enterprise-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: once the present PR merges, I will cherry-pick it on top of enterprise-4.18 in a new PR and assign it to you.
In response to this:
/cherrypick enterprise-4.18
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: once the present PR merges, I will cherry-pick it on top of enterprise-4.19 in a new PR and assign it to you.
In response to this:
/cherrypick enterprise-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: #95208 failed to apply on top of branch "enterprise-4.16":
Applying: added code
error: patch failed: modules/virt-hot-plugging-memory.adoc:20
error: modules/virt-hot-plugging-memory.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
A modules/virt-hot-plugging-memory.adoc
Patch failed at 0001 added code
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: new pull request created: #96392
In response to this:
/cherrypick enterprise-4.20
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: new pull request created: #96393
In response to this:
/cherrypick enterprise-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: #95208 failed to apply on top of branch "enterprise-4.18":
Applying: added code
error: patch failed: modules/virt-hot-plugging-memory.adoc:20
error: modules/virt-hot-plugging-memory.adoc: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Using index info to reconstruct a base tree...
M modules/virt-hot-plugging-memory.adoc
Patch failed at 0001 added code
In response to this:
/cherrypick enterprise-4.18
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ShaunaDiaz: new pull request created: #96394
In response to this:
/cherrypick enterprise-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@Vaishali-gif-rh You can create manual CPs for the failed picks as needed and resubmit, referencing this PR.