openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

TELCODOCS#2164: Added pin information

Open sr1kar99 opened this issue 5 months ago • 17 comments

Version(s): 4.17+

Issue: TELCODOCS-2164

Link to docs preview:

QE review:

  • [x] QE has approved this change.

sr1kar99 avatar Jun 20 '25 13:06 sr1kar99

@vitus133 Could you please review this PR? Thanks!

sr1kar99 avatar Jun 20 '25 14:06 sr1kar99

🤖 Mon Jun 30 18:48:53 - Prow CI generated the docs preview:

https://95044--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/configuring-ptp.html

ocpdocs-previewbot avatar Jun 20 '25 14:06 ocpdocs-previewbot

/lgtm

vitus133 avatar Jun 22 '25 06:06 vitus133

@ajaggapa Could you please review this PR? Thanks!

sr1kar99 avatar Jun 22 '25 18:06 sr1kar99

/label lgtm

hhassid avatar Jun 23 '25 14:06 hhassid

@hhassid: The label(s) /label lgtm cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 23 '25 14:06 openshift-ci[bot]

@sr1kar99: Those labels are not set on the issue: peer-review-needed

In response to this:

/label peer-review-in-progress /remove-label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jun 23 '25 19:06 openshift-ci[bot]

/label peer-review-needed

sr1kar99 avatar Jun 23 '25 20:06 sr1kar99

/remove-label peer-review-in-progress

sr1kar99 avatar Jun 23 '25 20:06 sr1kar99

/label peer-review-in-progress

aravipra avatar Jun 24 '25 06:06 aravipra

/remove-label peer-review-in-progress

aravipra avatar Jun 24 '25 07:06 aravipra

/remove-label peer-review-needed

aravipra avatar Jun 24 '25 07:06 aravipra

/label peer-review-done

aravipra avatar Jun 24 '25 07:06 aravipra

@sr1kar99 please wait for my comments to be double checked as I am new to peer review. @agantony please review the comments.

aravipra avatar Jun 24 '25 07:06 aravipra

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Jun 24 '25 09:06 openshift-ci[bot]

Added a few additional comments; overall lgtm!

Great suggestions! Updated the content. Thank you @agantony @aravipra

sr1kar99 avatar Jun 24 '25 09:06 sr1kar99

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jun 30 '25 18:06 openshift-ci[bot]

/label merge-review-needed

sr1kar99 avatar Jul 02 '25 06:07 sr1kar99

/cherry-pick enterprise-4.17

stevsmit avatar Jul 02 '25 14:07 stevsmit

/cherry-pick enterprise-4.18

stevsmit avatar Jul 02 '25 14:07 stevsmit

/cherry-pick enterprise-4.19

stevsmit avatar Jul 02 '25 14:07 stevsmit

/cherry-pick enterprise-4.20

stevsmit avatar Jul 02 '25 14:07 stevsmit

@stevsmit: new pull request created: #95522

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit: new pull request created: #95523

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit: new pull request created: #95524

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stevsmit: new pull request created: #95525

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.