openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OBSDOCS-1726: Port the "Installing log storage" sections to 5.8 and 6…

Open theashiot opened this issue 5 months ago • 7 comments

Version(s): 6.1

Issue: https://issues.redhat.com/browse/OBSDOCS-1726

Link to docs preview: https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • [ ] QE has approved this change.

Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423

theashiot avatar Jun 20 '25 11:06 theashiot

@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue.

In response to this:

Version(s): 6.1

Issue: https://issues.redhat.com/browse/OBSDOCS-1726

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 20 '25 11:06 openshift-ci-robot

🤖 Wed Jul 23 12:31:33 - Prow CI generated the docs preview:

https://95028--ocpdocs-pr.netlify.app/ https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

ocpdocs-previewbot avatar Jun 20 '25 12:06 ocpdocs-previewbot

/label merge-review-needed

theashiot avatar Jun 24 '25 12:06 theashiot

@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue.

In response to this:

Version(s): 6.1

Issue: https://issues.redhat.com/browse/OBSDOCS-1726

Link to docs preview: https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • [ ] QE has approved this change.

Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 24 '25 20:06 openshift-ci-robot

Thanks, @lahinson for the review and the wonderful suggestions! As this a manual cherry-pick PR, I've created a Jira to apply your comments; tbd in a separate PR. That PR will be to standalone-logging-docs-main and will then be cherry-picked to all the 6.x. Perhaps what we can do about this PR is to put this on hold until the other PR is merged and merge this just before cherry-picking the other PR. WDYT?

best,

ashwin

theashiot avatar Jun 25 '25 18:06 theashiot

Hi @theashiot - I completely missed that this PR was a manual cherry pick -- sorry about that! As I understand it, you do not need to request peer review for manual cherry picks. If you'd like to implement my suggestions, though, feel free to open the separate PR as you mentioned, and we can merge this before cherry picking the other PR.

lahinson avatar Jun 25 '25 18:06 lahinson

Note that the PR to address the review comments has been created: https://github.com/openshift/openshift-docs/pull/95640

theashiot avatar Jul 23 '25 12:07 theashiot

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 23 '25 12:07 openshift-ci[bot]

/label merge-review-needed

theashiot avatar Jul 23 '25 12:07 theashiot

/remove-label merge-review-needed /label merge-review-in-progress

briandooley avatar Jul 23 '25 12:07 briandooley