OBSDOCS-1726: Port the "Installing log storage" sections to 5.8 and 6…
Version(s): 6.1
Issue: https://issues.redhat.com/browse/OBSDOCS-1726
Link to docs preview: https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html
QE review:
- [ ] QE has approved this change.
Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423
@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue.
In response to this:
Version(s): 6.1
Issue: https://issues.redhat.com/browse/OBSDOCS-1726
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Wed Jul 23 12:31:33 - Prow CI generated the docs preview:
https://95028--ocpdocs-pr.netlify.app/ https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html
/label merge-review-needed
@theashiot: This pull request references OBSDOCS-1726 which is a valid jira issue.
In response to this:
Version(s): 6.1
Issue: https://issues.redhat.com/browse/OBSDOCS-1726
Link to docs preview: https://95028--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html
QE review:
- [ ] QE has approved this change.
Additional information: This is a manual cherry-pick of https://github.com/openshift/openshift-docs/pull/94423
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Thanks, @lahinson for the review and the wonderful suggestions! As this a manual cherry-pick PR, I've created a Jira to apply your comments; tbd in a separate PR. That PR will be to standalone-logging-docs-main and will then be cherry-picked to all the 6.x. Perhaps what we can do about this PR is to put this on hold until the other PR is merged and merge this just before cherry-picking the other PR. WDYT?
best,
ashwin
Hi @theashiot - I completely missed that this PR was a manual cherry pick -- sorry about that! As I understand it, you do not need to request peer review for manual cherry picks. If you'd like to implement my suggestions, though, feel free to open the separate PR as you mentioned, and we can merge this before cherry picking the other PR.
Note that the PR to address the review comments has been created: https://github.com/openshift/openshift-docs/pull/95640
@theashiot: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/label merge-review-needed
/remove-label merge-review-needed /label merge-review-in-progress