openshift-docs
openshift-docs copied to clipboard
OSDOCS-10810: Add additional routing capabilities
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.20, 4.19.z; 4.18.z
Issue:
Link to docs preview:
- About route advertisements
- Enabling route advertisements
- Disabling route advertisements
- Example route advertisements setup
QE review:
- [ ] QE has approved this change.
Additional information:
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s):
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
🤖 Tue Sep 02 15:45:26 - Prow CI generated the docs preview: https://89983--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.19,4.18.z
Issue:
Link to docs preview:
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/configuring-route-advertisements.html
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.19.z; 4.18.z
Issue:
Link to docs preview:
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/configuring-route-advertisements.html
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.19.z; 4.18.z
Issue:
Link to docs preview:
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
- https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.19.z; 4.18.z
Issue:
Link to docs preview:
- About route advertisements
- Enabling route advertisements
- Disabling route advertisements
- Example route advertisements setup
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest
@lahinson, thanks!
The branch/enterprise-4.20 label has been added to this PR.
This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).
If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.
@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.
In response to this:
- https://issues.redhat.com/browse/OSDOCS-10810
Version(s): 4.20, 4.19.z; 4.18.z
Issue:
Link to docs preview:
- About route advertisements
- Enabling route advertisements
- Disabling route advertisements
- Example route advertisements setup
QE review:
- [ ] QE has approved this change.
Additional information:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jechen0648, I've made some revisions to this; Can you take a look when you have a chance? Thanks!
@jab-rh see my other comment about inclusion of an answer to a common question: does this support route reflectors? The answer is that it does. This question comes from customers concerned about scaling up the number of routes to their (typically) very large numbers.
@jab-rh see my other comment about inclusion of an answer to a common question: does this support route reflectors? The answer is that it does. This question comes from customers concerned about scaling up the number of routes to their (typically) very large numbers.
This one is tricky to phrase. We support the use of route reflectors that are external to the cluster so in that sense they can be used to avoid a full mesh configuration.
However we don't support the cluster nodes themselves acting as a route reflector (yet) so you would depend on an external one for this.
LGTM
@jechen0648, is
oc get node <node_name> -o=jsonpath={.metadata.annotations.k8s\\.ovn\\.org/node-subnets}
With the escaped . as \\. correct? I haven't noticed this before.
Thanks!
@jab-rh: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
/cherry-pick enterprise-4.20
@jab-rh: new pull request created: #98369
In response to this:
/cherry-pick enterprise-4.20
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/cherry-pick enterprise-4.19
@jab-rh: #89983 failed to apply on top of branch "enterprise-4.19":
Applying: OSDOCS-10810: Add additional routing capabilities
Using index info to reconstruct a base tree...
M _topic_maps/_topic_map.yml
M modules/nw-operator-cr.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-operator-cr.adoc
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-10810: Add additional routing capabilities
In response to this:
/cherry-pick enterprise-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/cherry-pick enterprise-4.19
@jab-rh: new pull request created: #99590
In response to this:
/cherry-pick enterprise-4.19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.