openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OSDOCS-10810: Add additional routing capabilities

Open jab-rh opened this issue 8 months ago • 12 comments
trafficstars

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.20, 4.19.z; 4.18.z

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

jab-rh avatar Mar 10 '25 16:03 jab-rh

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 10 '25 16:03 openshift-ci-robot

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 10 '25 16:03 openshift-ci-robot

🤖 Tue Sep 02 15:45:26 - Prow CI generated the docs preview: https://89983--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-previewbot avatar Mar 10 '25 17:03 ocpdocs-previewbot

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.19,4.18.z

Issue:

Link to docs preview:

  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/configuring-route-advertisements.html
  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Mar 27 '25 01:03 openshift-ci-robot

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.19.z; 4.18.z

Issue:

Link to docs preview:

  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/configuring-route-advertisements.html
  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 02 '25 20:05 openshift-ci-robot

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.19.z; 4.18.z

Issue:

Link to docs preview:

  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/about-route-advertisements.html
  • https://89983--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/route_advertisements/example-route-advertisement-setup.html

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 21 '25 20:05 openshift-ci-robot

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.19.z; 4.18.z

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar May 21 '25 20:05 openshift-ci-robot

/retest

jab-rh avatar May 21 '25 20:05 jab-rh

@lahinson, thanks!

jab-rh avatar May 26 '25 03:05 jab-rh

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

bergerhoffer avatar Jun 16 '25 18:06 bergerhoffer

@jab-rh: This pull request references OSDOCS-10810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

  • https://issues.redhat.com/browse/OSDOCS-10810

Version(s): 4.20, 4.19.z; 4.18.z

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jun 25 '25 20:06 openshift-ci-robot

@jechen0648, I've made some revisions to this; Can you take a look when you have a chance? Thanks!

jab-rh avatar Jul 17 '25 02:07 jab-rh

@jab-rh see my other comment about inclusion of an answer to a common question: does this support route reflectors? The answer is that it does. This question comes from customers concerned about scaling up the number of routes to their (typically) very large numbers.

mcurry-rh avatar Aug 01 '25 18:08 mcurry-rh

@jab-rh see my other comment about inclusion of an answer to a common question: does this support route reflectors? The answer is that it does. This question comes from customers concerned about scaling up the number of routes to their (typically) very large numbers.

This one is tricky to phrase. We support the use of route reflectors that are external to the cluster so in that sense they can be used to avoid a full mesh configuration.

However we don't support the cluster nodes themselves acting as a route reflector (yet) so you would depend on an external one for this.

jcaamano avatar Aug 11 '25 15:08 jcaamano

LGTM

jcaamano avatar Aug 11 '25 15:08 jcaamano

@jechen0648, is

oc get node <node_name> -o=jsonpath={.metadata.annotations.k8s\\.ovn\\.org/node-subnets}

With the escaped . as \\. correct? I haven't noticed this before.

Thanks!

jab-rh avatar Aug 19 '25 16:08 jab-rh

@jab-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Sep 02 '25 15:09 openshift-ci[bot]

/cherry-pick enterprise-4.20

jab-rh avatar Sep 02 '25 15:09 jab-rh

@jab-rh: new pull request created: #98369

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherry-pick enterprise-4.19

jab-rh avatar Sep 23 '25 19:09 jab-rh

@jab-rh: #89983 failed to apply on top of branch "enterprise-4.19":

Applying: OSDOCS-10810: Add additional routing capabilities
Using index info to reconstruct a base tree...
M	_topic_maps/_topic_map.yml
M	modules/nw-operator-cr.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/nw-operator-cr.adoc
Auto-merging _topic_maps/_topic_map.yml
CONFLICT (content): Merge conflict in _topic_maps/_topic_map.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OSDOCS-10810: Add additional routing capabilities

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherry-pick enterprise-4.19

jab-rh avatar Sep 23 '25 19:09 jab-rh

@jab-rh: new pull request created: #99590

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.