openshift-docs
openshift-docs copied to clipboard
openshift
Adding note section for rolloutStrategy set to recreate for RWO
Adding note for set rolloutStrategy as recreate and replicas as 1 for RWO access modes of volume.
In doc[1] its not mention to use correct rolloutStrategy and replica.
[1] https://docs.openshift.com/container-platform/4.17/registry/configuring_registry_storage/configuring-registry-storage-osp.html#installation-registry-osp-creating-custom-pvc_configuring-registry-storage-openstack
🤖 Wed Jul 02 10:45:04 - Prow CI generated the docs preview:
https://89031--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-custom.html https://89031--ocpdocs-pr.netlify.app/openshift-enterprise/latest/registry/configuring_registry_storage/configuring-registry-storage-osp.html
@lpettyjo Thank you for the update. I made all required changes and created new commit. Please check this once and ask others to review this.
@duanwei33 @xiuwang i understand that we have these part available in other section of baremetal & nutanix. But i open this PR specially for OSP infra[1].
provisioner: cinder.csi.openstack.org
Since backend storage doesnt support RWX so we need to ensure the image registry runs a single replica and that the rollout strategy is Recreate.
[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/registry/setting-up-and-configuring-the-registry#configuring-registry-storage-openstack
@duanwei33 @xiuwang i understand that we have these part available in other section of baremetal & nutanix. But i open this PR specially for OSP infra[1].
provisioner: cinder.csi.openstack.orgSince backend storage doesnt support RWX so we need to ensure the image registry runs a single replica and that the rollout strategy is Recreate.
[1] https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/registry/setting-up-and-configuring-the-registry#configuring-registry-storage-openstack
Yes, I understand this applies only to OSP. However, how would a customer know what to do when they see the message: "RWO access mode requires rolloutStrategy set to Recreate and replica count set to 1"?
Also, I noticed that the recommended method is also mentioned in the later sections—just wondering, is there a specific reason we don’t follow the same approach here?
@duanwei33 This is for note section to set rolloutStrategy and replica count if they are using cinder.
Also i found previous issue[1] for same thing where mandre explained the reason.
[1] https://github.com/openshift/openshift-docs/issues/43053
Please check this once.
Hi sbiradar10, yes, I completely understand and agree with adding such a note for cinder RWO, my only concern is when we add "RWO access mode requires rolloutStrategy set to recreate and replica count set to 1", it would be better to also include how to configure these values, since neither parameter has been introduced earlier in the section.
As I mentioned, we already have the command to set them in other section after OSP, I just it would be useful to add the same.
oc patch config.imageregistry.operator.openshift.io/cluster --type=merge -p '{"spec":{"rolloutStrategy":"Recreate","replicas":1}}'
I hope you don’t mind me pointing this out, just thinking it could help users better understand and easy implentment.
@duanwei33 i made suggested changes in recent commits. Can you please check this once?
@sbiradar10: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale