openshift-docs
openshift-docs copied to clipboard
openshift
[SRVLOGIC-469]: Deploying workflows chapter does not use kn worklow plugin
Now it uses the kn workflow plugin
Version(s):
serverless-docs-1.34
serverless-docs-1.35
Issue:
Link to docs preview:
QE review:
- [ ] QE has approved this change.
Additional information:
@kaldesai @wmedvede @ricardozanini PTAL
Hi @domhanak. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Need to also fix the devmode and the other referenced guide. Ty for review, so far will ping you when I push the changes
🤖 Thu Jan 16 15:24:14 - Prow CI generated the docs preview:
https://85916--ocpdocs-pr.netlify.app/openshift-serverless/latest/serverless-logic/serverless-logic-getting-started/serverless-logic-deploying-workflows.html
@domhanak Once you have drafted the content, you can assign this PR for the peer review process by adding a /label peer-review-needed label to it.
Note: Make sure you have squashed down the commit to only 1.
The OpenShift peer review squad will then peer review this PR, and you can proceed with the merge review process.
@kaldesai not yet I still feel like some parts can be enhanced. I ll ping you :)
@domhanak: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
@adellape You made me think hard about the guide and how it looks as whole. I am trying to improve it
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Issue is stale as I do not have the bandwith for this. Either pick this up @kaldesai or close please.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.