openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

[OSDOCS-12035]: Adding tenancy docs to HCP on AWS

Open lahinson opened this issue 1 year ago • 7 comments

Version(s): 4.17+

Issue: https://issues.redhat.com/browse/OSDOCS-12035

Link to docs preview: https://83719--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html#hcp-aws-deploy-hc_hcp-deploy-aws

QE review:

  • [x] QE has approved this change.

Additional information:

lahinson avatar Oct 17 '24 18:10 lahinson

🤖 Wed Nov 06 14:46:50 - Prow CI generated the docs preview:

https://83719--ocpdocs-pr.netlify.app/openshift-enterprise/latest/hosted_control_planes/hcp-deploy/hcp-deploy-aws.html

ocpdocs-previewbot avatar Oct 17 '24 18:10 ocpdocs-previewbot

/lgtm

heliubj18 avatar Oct 25 '24 06:10 heliubj18

/label peer-review-in-progress

michaelryanpeter avatar Oct 25 '24 14:10 michaelryanpeter

@michaelryanpeter: The label(s) /remove-label peer-review-need cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

Just one comment on phrasing. Otherwise, LGTM.

/remove-label peer-review-need /remove-label peer-review-in-progress /label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Oct 25 '24 15:10 openshift-ci[bot]

/remove-label peer-review-needed

michaelryanpeter avatar Oct 25 '24 15:10 michaelryanpeter

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Oct 25 '24 16:10 openshift-ci[bot]

@lahinson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 06 '24 14:11 openshift-ci[bot]

/cherrypick enterprise-4.17

lahinson avatar Nov 06 '24 14:11 lahinson

/cherrypick enterprise-4.18

lahinson avatar Nov 06 '24 14:11 lahinson

@lahinson: cannot checkout 4.17: error checking out "4.17": exit status 1 error: pathspec '4.17' did not match any file(s) known to git

In response to this:

/cherrypick 4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lahinson: new pull request created: #84533

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lahinson: new pull request created: #84534

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.