openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OADP-1986: OADP doc for ROSA needs uninstallation steps

Open anarnold97 opened this issue 1 year ago • 10 comments

JIRA

As this ticket asks for documentation that exists elsewhere in OCP docs, I think it would be ok to link to those pieces of documentation. I have added the relevant links to Additional resources:

Additional resources
image

I have created a snippet with an IFDEF statement to include the relevant ROSA links only in the OADP ROSA docs. This way I can use this snippet in two locations as suggested by Amos.

VERSION

  • OCP 4.12 and later

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

anarnold97 avatar Oct 17 '24 15:10 anarnold97

@anarnold97: This pull request references OADP-1986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 15:10 openshift-ci-robot

🤖 Thu Oct 24 21:52:37 - Prow CI generated the docs preview:

https://83694--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/oadp-installing-operator.html https://83694--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-rosa/oadp-rosa-backing-up-applications.html

ocpdocs-previewbot avatar Oct 17 '24 15:10 ocpdocs-previewbot

@anarnold97: This pull request references OADP-1986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

JIRA

As this ticket asks for documentation that exists elsewhere in OCP docs, I think it would be ok to link to those pieces of documentation. I have added the relevant links to Additional resources:

Additional resources
image

VERSION

  • OCP 4.12 and later

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 17 '24 20:10 openshift-ci-robot

/label oadp

anarnold97 avatar Oct 24 '24 17:10 anarnold97

@amastbau - please can i get a review

Thanks

anarnold97 avatar Oct 24 '24 17:10 anarnold97

@anarnold97 maybe all the operators related links put here instead?

https://83694--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/oadp-installing-operator

amastbau avatar Oct 24 '24 18:10 amastbau

@anarnold97: This pull request references OADP-1986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

JIRA

As this ticket asks for documentation that exists elsewhere in OCP docs, I think it would be ok to link to those pieces of documentation. I have added the relevant links to Additional resources:

Additional resources
image

VERSION

  • OCP 4.12 and later

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 24 '24 21:10 openshift-ci-robot

@amastbau - how about we change it to a snippet and include it in both places. I will include an ifdef to include the ROSA links solely in the OADP-ROSA doc (as this was central to the ticket)

anarnold97 avatar Oct 24 '24 21:10 anarnold97

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 24 '24 21:10 openshift-ci[bot]

@anarnold97: This pull request references OADP-1986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

JIRA

As this ticket asks for documentation that exists elsewhere in OCP docs, I think it would be ok to link to those pieces of documentation. I have added the relevant links to Additional resources:

Additional resources
image

I have created a snippet with an IFDEF statement to include the relevant ROSA links only in the OADP ROSA docs. This way I can use this snippet in two locations as suggested by Amos.

VERSION

  • OCP 4.12 and later

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 25 '24 15:10 openshift-ci-robot

/LGTM

amastbau avatar Oct 29 '24 20:10 amastbau

/label peer-review-needed

anarnold97 avatar Oct 29 '24 20:10 anarnold97

/label peer-review-in-progress

max-cx avatar Oct 30 '24 09:10 max-cx

/remove-label peer-review-needed

max-cx avatar Oct 30 '24 09:10 max-cx

@anarnold97, I have peer-reviewed this PR, but it's the end of my peer-review squad week. Feel free to take your time to review and consider my suggestions and revise this PR as needed and then request a new peer review again later.

max-cx avatar Nov 01 '24 14:11 max-cx

/remove-label peer-review-in-progress

max-cx avatar Nov 01 '24 14:11 max-cx