openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

ROX-26652: update scanner OS support

Open RTann opened this issue 1 year ago • 7 comments

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652

Link to docs preview:

https://83675--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html

QE review:

  • [ ] QE has approved this change.

Additional information:

I decided to move the OS support to the top, as that tends to be the first thing people would look for. I also made a super minor change to the JavaScript line to remove Node.js (not needed). I also added the related package managers next to the package formats, so it'll be clearer for those who are not familiar with the formats and only the managers

RTann avatar Oct 16 '24 22:10 RTann

@RTann: This pull request references ROX-26652 which is a valid jira issue.

In response to this:

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 22:10 openshift-ci-robot

@RTann: This pull request references ROX-26652 which is a valid jira issue.

In response to this:

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652

Link to docs preview:

QE review:

  • [ ] QE has approved this change.

Additional information:

I decided to move the OS support to the top, as that tends to be the first thing people would look for. I also made a super minor change to the JavaScript line to remove Node.js (not needed). I also added the related package managers next to the package formats, so it'll be clearer for those who are not familiar with the formats and only the managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 22:10 openshift-ci-robot

🤖 Thu Oct 31 17:55:30 - Prow CI generated the docs preview:

https://83675--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html

ocpdocs-previewbot avatar Oct 16 '24 22:10 ocpdocs-previewbot

@RTann: This pull request references ROX-26652 which is a valid jira issue.

In response to this:

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652

Link to docs preview:

https://83675--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html

QE review:

  • [ ] QE has approved this change.

Additional information:

I decided to move the OS support to the top, as that tends to be the first thing people would look for. I also made a super minor change to the JavaScript line to remove Node.js (not needed). I also added the related package managers next to the package formats, so it'll be clearer for those who are not familiar with the formats and only the managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 16 '24 22:10 openshift-ci-robot

@kcarmichael08 I made the requested changes, but for the package format one, I turned it into a table. I figured it'd read better that way. Let me know what you think, thanks

RTann avatar Oct 24 '24 21:10 RTann

@kcarmichael08 I also decided to turn the language support into a table too. Let's see how it looks :)

RTann avatar Oct 24 '24 21:10 RTann

@kcarmichael08 I made the requested changes, but for the package format one, I turned it into a table. I figured it'd read better that way. Let me know what you think, thanks

I think that's OK. It's a judgment call - it's easier for people reading, but for people who use a screenreader, sometimes it's not (depending on the columns/rows/amount of data). In this case I think it's fine.

kcarmichael08 avatar Oct 28 '24 17:10 kcarmichael08

@kcarmichael08 I made two minor updates to the language table and added the headers, as requested

RTann avatar Oct 28 '24 20:10 RTann

@RTann: This pull request references ROX-26652 which is a valid jira issue.

In response to this:

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652
  • https://issues.redhat.com/browse/ROX-26470

Link to docs preview:

https://83675--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html

QE review:

  • [ ] QE has approved this change.

Additional information:

I decided to move the OS support to the top, as that tends to be the first thing people would look for. I also made a super minor change to the JavaScript line to remove Node.js (not needed). I also added the related package managers next to the package formats, so it'll be clearer for those who are not familiar with the formats and only the managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 29 '24 00:10 openshift-ci-robot

@RTann: This pull request references ROX-26652 which is a valid jira issue.

In response to this:

Version(s):

  • 4.6

Issue:

  • https://issues.redhat.com/browse/ROX-26652
  • https://issues.redhat.com/browse/ROX-26470

Link to docs preview:

https://83675--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/examine-images-for-vulnerabilities.html

QE review: ACS has no QE, approved by SME

  • [ ] QE has approved this change.

Additional information:

I decided to move the OS support to the top, as that tends to be the first thing people would look for. I also made a super minor change to the JavaScript line to remove Node.js (not needed). I also added the related package managers next to the package formats, so it'll be clearer for those who are not familiar with the formats and only the managers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Oct 31 '24 14:10 openshift-ci-robot

@RTann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Oct 31 '24 17:10 openshift-ci[bot]

LGTM

kcarmichael08 avatar Oct 31 '24 18:10 kcarmichael08

/cherrypick rhacs-docs-4.6

kcarmichael08 avatar Oct 31 '24 18:10 kcarmichael08

@kcarmichael08: new pull request created: #84333

In response to this:

/cherrypick rhacs-docs-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.