openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

WIP PR for SRVLOGIC-355: Add the Openshift Serverless Logic GA entry in the Serverless 1.33 release notes.

Open kaldesai opened this issue 1 year ago • 4 comments
trafficstars

Affecting versions: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-355

Doc previews:

kaldesai avatar Jul 05 '24 05:07 kaldesai

@kaldesai: This pull request references SRVLOGIC-355 which is a valid jira issue.

In response to this:

Affecting versions: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-355

Doc previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 05 '24 05:07 openshift-ci-robot

🤖 Mon Jul 15 14:42:08 - Prow CI generated the docs preview:

https://78505--ocpdocs-pr.netlify.app/openshift-serverless/latest/about/serverless-release-notes.html

ocpdocs-previewbot avatar Jul 05 '24 05:07 ocpdocs-previewbot

@kaldesai: This pull request references SRVLOGIC-355 which is a valid jira issue.

In response to this:

Affecting versions: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-355

Doc previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 05 '24 06:07 openshift-ci-robot

@kaldesai: This pull request references SRVLOGIC-355 which is a valid jira issue.

In response to this:

Affecting versions: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-355

Doc previews:

Notes for the reviewers: {ServerlessLogicOperatorName} will not reflect now because I have added this attribute in the (https://github.com/openshift/openshift-docs/pull/76488). Once we merge that PR this attribute will reflect correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 11 '24 15:07 openshift-ci-robot

/label peer-review-needed

kaldesai avatar Jul 11 '24 15:07 kaldesai

/label merge-review-needed

kaldesai avatar Jul 12 '24 11:07 kaldesai

/hold

​please hold off on merging the PR as we are waiting for the product team to give us the green signal (GA is on 8 July). Once we receive their approval, the PR will be ready to merge with everything in place. Until then you can verify the content and add LGTM if everything is fine.

kaldesai avatar Jul 12 '24 11:07 kaldesai

@kaldesai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 15 '24 14:07 openshift-ci[bot]

@kaldesai: This pull request references SRVLOGIC-355 which is a valid jira issue.

In response to this:

Affecting versions: serverless-docs-1.33

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-355

Doc previews:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot avatar Jul 15 '24 14:07 openshift-ci-robot

PR looks good to merge whenever you do request it to be merged (provided you request a merge after the PR that introduces the attribute is merged and you rebase this PR)

@skopacz1 The PR (https://github.com/openshift/openshift-docs/pull/76488) is now merged. And the {ServerlessLogicOperatorName} attribute is now reflecting correctly.

kaldesai avatar Jul 15 '24 14:07 kaldesai

/cherrypick serverless-docs-1.33

kalexand-rh avatar Jul 15 '24 15:07 kalexand-rh

@kalexand-rh: new pull request created: #78881

In response to this:

/cherrypick serverless-docs-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.