openshift-docs icon indicating copy to clipboard operation
openshift-docs copied to clipboard

OCPBUGS-33379_2#amending vMotion text

Open brendan-daly-red-hat opened this issue 1 year ago • 8 comments

Version: 4.13

Issue: https://issues.redhat.com/browse/OCPBUGS-33379

Link to docs preview: https://78481--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_vmc/installing-vmc#installation-vsphere-installer-infra-requirements_installing-vmc

QE review:

  • [ ] QE has approved this change.

Additional information:

brendan-daly-red-hat avatar Jul 04 '24 09:07 brendan-daly-red-hat

🤖 Thu Jul 11 16:14:52 - Prow CI generated the docs preview: https://78481--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

ocpdocs-previewbot avatar Jul 04 '24 09:07 ocpdocs-previewbot

@gpei, PTAL

brendan-daly-red-hat avatar Jul 04 '24 10:07 brendan-daly-red-hat

@sgaoshang could you please take a look at this?

gpei avatar Jul 05 '24 01:07 gpei

@brendan-daly-red-hat shall we also update Installing on vSphere section here , pls note that from 4.14, we do not have Installing on VMC part anymore.

Pls ignore it, I see Installing on vSphere part is already updated.

sgaoshang avatar Jul 05 '24 01:07 sgaoshang

We are aware that VMware's official documentation does not have the name "compute-only vMotion".

  1. Is this a counter explanation to VMware's Storage vMotion?
     If Yes, we assume it means VMware compute vMotion, not VMware Storage vMotion.
     But, we are aware that VMware's official documentation does not have the name "compute-only vMotion".

compute-only vMotion in doc means VMware compute vMotion, pls see pic, we can migrate both OCP compute and control plane machines, so Using vMotion to migrate machine workloads is generally supported is not accurate. IMO we just need to use the correct term to replace compute-only vMotion image

sgaoshang avatar Jul 05 '24 01:07 sgaoshang

/remove-label peer-review-needed

/label peer-review-in-progress

dfitzmau avatar Jul 05 '24 11:07 dfitzmau

@dfitzmau: Those labels are not set on the issue: peer-review-needed

In response to this:

/remove-label peer-review-needed

/label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Jul 05 '24 11:07 openshift-ci[bot]

@sgaoshang, Thanks for your review comments. Could you review the update?

brendan-daly-red-hat avatar Jul 09 '24 15:07 brendan-daly-red-hat

@brendan-daly-red-hat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 16:07 openshift-ci[bot]

@sgaoshang, I updated the draft text based on comments in https://issues.redhat.com/browse/OCPBUGS-33379. Can you take a look? Thanks.

brendan-daly-red-hat avatar Jul 11 '24 16:07 brendan-daly-red-hat

/lgtm

sgaoshang avatar Jul 12 '24 01:07 sgaoshang

/label merge-review-needed

brendan-daly-red-hat avatar Jul 12 '24 13:07 brendan-daly-red-hat

/cherrypick enterprise-4.14

bscott-rh avatar Jul 24 '24 13:07 bscott-rh

@bscott-rh: new pull request created: #79361

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherrypick enterprise-4.15

bscott-rh avatar Jul 24 '24 13:07 bscott-rh

@bscott-rh: new pull request created: #79362

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherrypick enterprise-4.16

bscott-rh avatar Jul 24 '24 13:07 bscott-rh

@bscott-rh: new pull request created: #79363

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/cherrypick enterprise-4.17

bscott-rh avatar Jul 24 '24 13:07 bscott-rh

@bscott-rh: new pull request created: #79364

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.