openshift-docs
openshift-docs copied to clipboard
openshift
Terraform Post-Merge Clean-up
This PR captures the missed feedback for #77311
- Updates to the cluster overview:
- Additional resource updates:
🤖 Fri Jun 28 15:42:10 - Prow CI generated the docs preview:
https://78211--ocpdocs-pr.netlify.app/ https://78211--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_getting_started/rosa-quickstart-guide-ui.html https://78211--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-sts-creating-a-cluster-quickly.html https://78211--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/terraform/rosa-hcp-creating-a-cluster-quickly-terraform.html https://78211--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/rosa-sts-creating-a-cluster-quickly.html https://78211--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_install_access_delete_clusters/terraform/rosa-classic-creating-a-cluster-quickly-terraform.html
@EricPonvelle: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@radtriste and @andyrepton - can you two review this PR that caught the items that I missed in #77311? Thank you!
@radtriste in this comment, you mentioned these two items:
Some cluster specifications has no sense in HCP, like:
Control plane node configuration component Infrastructure plane node configuration component ~~Cluster settings -> Default EC2 IMDS endpoints~~ ~~Encryption -> No KMS key encryption by default~~
Would I remove those two rows from the overview sections on the HCP guides?
@radtriste in this comment, you mentioned these two items:
Some cluster specifications has no sense in HCP, like: Control plane node configuration component Infrastructure plane node configuration component ~Cluster settings -> Default EC2 IMDS endpoints~ ~Encryption -> No KMS key encryption by default~
Would I remove those two rows from the overview sections on the HCP guides?
In HCP, we do not have those CP and Infrastucture nodes as they are managed by Red Hat, we only have the compute nodes.
Where do you mean with overview sections on the HCP guides ?
@radtriste, the way we structured rosa-sts-overview-of-the-default-cluster-specificiations.adoc is that it shows differently depending on the context. In HCP, we show it like this for the normal installation method and like this for Terraform.
In the classic guides, you can see the CP and Infrastructure nodes on the same table if you use the normal installation guide or if you use the Terraform guide.
I'm not sure if I clarified or muddled things...
I think I was able to follow the different flavors and check that everything appearing is what is supposed to/not supposed to. Tricky - nice job with parsing that! LGTM peer review wise.
@EricPonvelle: new pull request created: #78524
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@EricPonvelle: new pull request created: #78525
In response to this:
/cherrypick enterprise-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.16 from head openshift-cherrypick-robot:cherry-pick-78211-to-enterprise-4.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-78211-to-enterprise-4.16."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}
In response to this:
/cherrypick enterprise-4.16
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@EricPonvelle: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.17 from head openshift-cherrypick-robot:cherry-pick-78211-to-enterprise-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-78211-to-enterprise-4.17."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}
In response to this:
/cherrypick enterprise-4.17
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.